Check for and return null for non-planar and/or open curves

[IsakNaslundBh]

Issues addressed by this PR

Closes #43

Checks that the input curve is closed and/or planar, and returns null if found, as method was returning non-sensical results for those cases.

Adding tolerance input with default value to allow to control the checks for closedness as well as planarity.

Test files

Alpha test script:

https://burohappold.sharepoint.com/:f:/s/BHoM/EjCPW4vnq01MpH8Hd1LH7yEBS8rQTHYsPDoTOKXxHUA2iw?e=54PEjT

Script testing closed/non-planar curve errors:

https://burohappold.sharepoint.com/:f:/s/BHoM/EqxYAD6Hl09DpkVDdgf_Z3sBlbSHUCT6sCzApgwWCd4jyQ?e=KLduTh

Changelog

Additional comments

@tg359 @jamesramsden-bh , I think this method is used in BEnv toolkits, so great if one of you can confirm that you are happy with this, and make sure your workflows still function.

[IsakNaslundBh]

@BHoMBot check compliance

[bhombot-ci]

@IsakNaslundBh to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

There are 1 requests in the queue ahead of you.

[bhombot-ci]

@IsakNaslundBh to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

There are 7 requests in the queue ahead of you.

[bhombot-ci]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check branch-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check copyright-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

@IsakNaslundBh fix requested for project compliance.

The errors with the CSProject (.csproj) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix project file ref. 8387982549

[bhombot-ci]

@IsakNaslundBh fix requested for project compliance.

The errors with the CSProject (.csproj) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix project file ref. 8387982549

[IsakNaslundBh]

@BHoMBot fix project file ref. 8387982549

[bhombot-ci]

@IsakNaslundBh I have queued up your request to fix the csproj file(s). There are 4 requests in the queue ahead of you.

[bhombot-ci]

@IsakNaslundBh I have queued up your request to fix the csproj file(s). There are 5 requests in the queue ahead of you.

[bhombot-ci]

@IsakNaslundBh I am now going to fix the project compliance in accordance with the annotations previously made.

[bhombot-ci]

@IsakNaslundBh to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request.

[bhombot-ci]

@IsakNaslundBh I am now going to fix the project compliance in accordance with the annotations previously made.

[bhombot-ci]

@IsakNaslundBh to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request.

[FraserGreenroyd]

@BHoMBot check versioning

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check versioning

There are 12 requests in the queue ahead of you.

[tg359]

Tested and the checks work. I couldn't find any references in the TK's I thought they'd be in - but non-planar offsets wouldn't be possible in any workflows I know off, so approving.

[FraserGreenroyd]

@BHoMBot check compliance
@BHoMBot check required
@BHoMBot check ready-to-merge

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance
• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer
• check ready-to-merge

[bhombot-ci]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

[FraserGreenroyd]

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: dataset-compliance

[bhombot-ci]

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.