-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated file name to match method name #117
Updated file name to match method name #117
Conversation
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 3 requests in the queue ahead of you. |
-Create methods names must match type of item created
-per Fraser's suggestion, we are still using CarbonQueryDatabaseRequest for the method name, but created a subfolder named GetRequest inside Create
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check required |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
The check |
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compliance is satisfied so all good, thanks @desaiwangBH
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 12 requests in the queue ahead of you. |
Issues addressed by this PR
Closes #112
Test files
Changelog
Additional comments