Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated file name to match method name #117

Merged

Conversation

desaiwangBH
Copy link
Contributor

Issues addressed by this PR

Closes #112

  • changed GetRequest.cs to CarbonQueryDatabaseRequest.cs to match method name inside file

Test files

Changelog

Additional comments

@desaiwangBH desaiwangBH added the type:compliance Non-conforming to code guidelines label Jun 30, 2023
@desaiwangBH desaiwangBH self-assigned this Jun 30, 2023
@FraserGreenroyd FraserGreenroyd changed the title 6.2 Compliance: Updated file name to match method name Updated file name to match method name Jun 30, 2023
@FraserGreenroyd
Copy link

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 30, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 3 requests in the queue ahead of you.

-Create methods names must match type of item created
-per Fraser's suggestion, we are still using CarbonQueryDatabaseRequest for the method name, but created a subfolder named GetRequest inside Create
@FraserGreenroyd
Copy link

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 30, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@FraserGreenroyd
Copy link

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 30, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 1 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 30, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 30, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 30, 2023

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compliance is satisfied so all good, thanks @desaiwangBH

@FraserGreenroyd
Copy link

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 30, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 12 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 4bb4772 into develop Jun 30, 2023
@FraserGreenroyd FraserGreenroyd deleted the CarbonQueryDatabase_Toolkit-#112-CodeCompliance branch June 30, 2023 16:16
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6.2 Code compliance fixes
2 participants