Solving the slow execution of CollectOutputTypes on Custom objects #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FraserGreenroyd
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Approving based on code review and discussion with @adecler during the historic issue closure today, this resolves the speed issue and happy to deploy to alpha to be tested by a broader user base during the milestone to check it isn't causing any problems with things we haven't considered today.
|
@FraserGreenroyd to confirm, the following actions are now queued:
|
|
@BHoMBot check ready-to-merge |
|
@FraserGreenroyd to confirm, the following actions are now queued:
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #478
Test files
ExplodeDeleteTest.zip
The call to
OutputParamswas very slow (~20s) so I added it to the scrip to confirm in now takes only a few milliseconds.