Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to connect and trigger events when Usage Log is triggered #425

Merged
merged 6 commits into from
Aug 24, 2022

Conversation

FraserGreenroyd
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd commented Aug 11, 2022

See the details listed on this linked PR.

@FraserGreenroyd FraserGreenroyd marked this pull request as ready for review August 12, 2022 09:21
Copy link

@alexissantella alexissantella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes based on code review.

UI_oM/TriggerLogUsageArgs.cs Show resolved Hide resolved
UI_oM/TriggerLogUsageArgs.cs Outdated Show resolved Hide resolved
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 19, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance

There are 21 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 19, 2022

@FraserGreenroyd fix requested for copyright headers.

The errors with the copyright headers on the CS (.cs) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

Each CS (.cs) file that does not have the current copyright header will have it applied. The current copyright header can be examined here.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix copyright headers ref. 7921146293

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot fix copyright headers ref. 7921146293

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 19, 2022

@FraserGreenroyd I have queued up your request to fix copyright headers. There are 0 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 19, 2022

@FraserGreenroyd I am now going to fix the copyright compliance in accordance with the annotations previously made.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 19, 2022

@FraserGreenroyd to confirm I have now resolved the copyright compliance and pushed a commit to this Pull Request.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 24, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 24, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core

@travispotterBH travispotterBH self-requested a review August 24, 2022 18:49
Copy link

@travispotterBH travispotterBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 24, 2022

@FraserGreenroyd just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoMAnalytics_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 24, 2022

@FraserGreenroyd just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoMAnalytics_Toolkit

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 24, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 2 requests in the queue ahead of you.

Copy link

@alexissantella alexissantella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on reviews of depending PRs.
See: BHoM/BHoMAnalytics_Toolkit#35

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 24, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 196f0de into main Aug 24, 2022
@FraserGreenroyd FraserGreenroyd deleted the BHoMAnalytics_Toolkit-#34-ProjectID branch August 24, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants