Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lusas211 to altconfigs #224

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

peterjamesnugent
Copy link
Member

NOTE: Depends on

BHoM/Lusas_Toolkit#410

Issues addressed by this PR

Closes #223

Test files

Changelog

Additional comments

@peterjamesnugent peterjamesnugent added the type:external-api-changes Imposed changes, including from dependency across other BHoM repos label Aug 27, 2024
@peterjamesnugent peterjamesnugent self-assigned this Aug 27, 2024
@peterjamesnugent peterjamesnugent changed the title Add Lusas V21.1 to alt configs Add Lusas211 to altconfigs Aug 28, 2024
@peterjamesnugent
Copy link
Member Author

@BHoMBot check copyright-compliance
@BHoMBot check installer

Copy link

bhombot-ci bot commented Sep 5, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check copyright-compliance
  • check installer

There are 87 requests in the queue ahead of you.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check installer

Copy link

bhombot-ci bot commented Sep 6, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check installer

There are 1 requests in the queue ahead of you.

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the basis of code review and that the installer check is passing.

@IsakNaslundBh IsakNaslundBh merged commit cbf84f8 into develop Sep 6, 2024
2 checks passed
@IsakNaslundBh IsakNaslundBh deleted the Lusas_Toolkit-#409-UpgradeToLusas211 branch September 6, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Lusas211 to altconfigs
2 participants