Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verifiaction: Add reference to Diffing_Engine to properly access the IsEqual method #3414

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Sep 5, 2024

Issues addressed by this PR

Closes #3413

Fixes references to the verification solution that broke after BHoM/Test_Toolkit#474

Test files

Make sure compiles, and checks should be actually running on this PR.

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added severity:critical No workaround exists. Essential to continue type:bug Error or unexpected behaviour labels Sep 5, 2024
@IsakNaslundBh IsakNaslundBh self-assigned this Sep 5, 2024
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check serialisation
@BHoMBot check null-handling

Copy link

bhombot-ci bot commented Sep 5, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check serialisation
  • check null-handling

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check required
@BHoMBot check compliance

Copy link

bhombot-ci bot commented Sep 5, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

Copy link

bhombot-ci bot commented Sep 5, 2024

The check serialisation has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the basis of a discussion with @IsakNaslundBh

@IsakNaslundBh
Copy link
Contributor Author

Will dispensate null handling on this PR, as the fact that it is failing now is a clear indication that it is now running, while before it was silently just being skipped due to the build errors on the verification solution.

For code compliance, I will also dispensate, as this is a project sitting outside the general Engine.

Copy link

bhombot-ci bot commented Sep 5, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Sep 5, 2024

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Sep 5, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check unit-tests

There are 13 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Sep 5, 2024

FAO: @adecler @pawelbaran @IsakNaslundBh
@IsakNaslundBh is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is code-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 29713296153

Copy link

bhombot-ci bot commented Sep 5, 2024

FAO: @adecler @pawelbaran @IsakNaslundBh
@IsakNaslundBh is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is null-handling.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 29712010796

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 29713296153

Copy link

bhombot-ci bot commented Sep 5, 2024

@IsakNaslundBh I have now provided a passing check on reference 29713296153 as requested.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 29712010796

Copy link

bhombot-ci bot commented Sep 5, 2024

@IsakNaslundBh I have now provided a passing check on reference 29712010796 as requested.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Sep 5, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

@IsakNaslundBh IsakNaslundBh merged commit 1fb3e68 into develop Sep 5, 2024
13 checks passed
@IsakNaslundBh IsakNaslundBh deleted the Verification-#3413-FixBuildIssuesInVerificationSolution branch September 5, 2024 08:11
@BHoMBot BHoMBot mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity:critical No workaround exists. Essential to continue type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VerificationSolution does not build after removal of IsEqual method from Test_Toolkit
2 participants