-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verifiaction: Add reference to Diffing_Engine to properly access the IsEqual method #3414
Verifiaction: Add reference to Diffing_Engine to properly access the IsEqual method #3414
Conversation
@IsakNaslundBh to confirm, the following actions are now queued:
|
@IsakNaslundBh to confirm, the following actions are now queued:
|
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on the basis of a discussion with @IsakNaslundBh
Will dispensate null handling on this PR, as the fact that it is failing now is a clear indication that it is now running, while before it was silently just being skipped due to the build errors on the verification solution. For code compliance, I will also dispensate, as this is a project sitting outside the general Engine. |
The check |
The check |
@BHoMBot check unit-tests |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 13 requests in the queue ahead of you. |
FAO: @adecler @pawelbaran @IsakNaslundBh The check they wish to have dispensation on is code-compliance. If you are providing dispensation on this occasion, please reply with:
|
FAO: @adecler @pawelbaran @IsakNaslundBh The check they wish to have dispensation on is null-handling. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 29713296153 |
@IsakNaslundBh I have now provided a passing check on reference |
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 29712010796 |
@IsakNaslundBh I have now provided a passing check on reference |
@BHoMBot check ready-to-merge |
@IsakNaslundBh to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #3413
Fixes references to the verification solution that broke after BHoM/Test_Toolkit#474
Test files
Make sure compiles, and checks should be actually running on this PR.
Changelog
Additional comments