-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BHoM_Engine: Additional check for assembly qualified type without version for Create EngineType #3399
BHoM_Engine: Additional check for assembly qualified type without version for Create EngineType #3399
Conversation
@BHoMBot check compliance |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
The check |
The check |
@BHoMBot check versioning |
@IsakNaslundBh to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good, I tested it both in GH and Revit with positive results. One minor code comment left, besides that all good 👍
@IsakNaslundBh to confirm, the following actions are now queued:
|
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to approve following code review and testing 👍
@BHoMBot check ready-to-merge |
@pawelbaran to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #3398
Add additional check for assembly qualified name without version. Important for edgecase of same namespace and typename, from different assemblies for types serialized in an older major version. Only runs this additional step if more than one type is found.
Generally having this duplication should most likely be avoided, but as that has not been enforced, and was not an issue before #3389 which fixed other critical issues, but introduced this edge case problem, we should still attempt to make sure it works after that fix.
Test files
All query components should deserialise correctly:
On Sharepointhttps://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/03_Alpha/BuroHappoldEngineering/ModelLaundry_Toolkit/[BuroHappold_BHoM_v3.3.beta_Structures_ML_BasicWorkFlow.gh](https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/03_Alpha/BuroHappoldEngineering/ModelLaundry_Toolkit/BuroHappold_BHoM_v3.3.beta_Structures_ML_BasicWorkFlow.gh?csf=1&web=1&e=6E7xl3)?csf=1&web=1&e=6E7xl3
Changelog
Additional comments