Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ground_Engine: Consolidate method for a Borehole #3372

Merged
merged 6 commits into from
Jul 17, 2024

Conversation

peterjamesnugent
Copy link
Member

Issues addressed by this PR

Closes #3271

Test files

https://burohappold.sharepoint.com/:u:/s/BHoM/Ed88wg7PXYJEmTkOJcxKgkgBDI2rWoJoVNS3sJPTk4iwJw?e=24SqQ2

Changelog

  • Added ConsolidateStrata method that uses a property to combine sequential Stratum. For example, combining Stratum with the same ObservedGeology property.

Additional comments

@peterjamesnugent peterjamesnugent added the type:feature New capability or enhancement label Jul 10, 2024
@peterjamesnugent peterjamesnugent added this to the BHoM 7.3 β MVP milestone Jul 10, 2024
@peterjamesnugent peterjamesnugent self-assigned this Jul 10, 2024
@peterjamesnugent
Copy link
Member Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jul 10, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 2 requests in the queue ahead of you.

jtrainor1
jtrainor1 previously approved these changes Jul 12, 2024
Copy link

@jtrainor1 jtrainor1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Component manages to combine the AGS data correctly.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Jul 16, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check unit-tests

@pawelbaran
Copy link
Member

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Jul 17, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check unit-tests

@pawelbaran
Copy link
Member

@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Jul 17, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check copyright-compliance

@pawelbaran
Copy link
Member

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Jul 17, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check unit-tests

@peterjamesnugent peterjamesnugent force-pushed the Ground_Engine-#3271-#ConsolidateMethodForStrata branch from cd6a610 to 3329a92 Compare July 17, 2024 09:25
@pawelbaran
Copy link
Member

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Jul 17, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check unit-tests

@pawelbaran
Copy link
Member

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Jul 17, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check unit-tests

@pawelbaran
Copy link
Member

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Jul 17, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check unit-tests

@pawelbaran
Copy link
Member

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jul 17, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 6 requests in the queue ahead of you.

@pawelbaran
Copy link
Member

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

Copy link

bhombot-ci bot commented Jul 17, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation

There are 3 requests in the queue ahead of you.

@pawelbaran
Copy link
Member

@BHoMBot check installer
@BHoMBot check versioning

Copy link

bhombot-ci bot commented Jul 17, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check installer
  • check versioning

There are 2 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Jul 17, 2024

FAO: @FraserGreenroyd
@pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is unit-tests.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 27566220787

@pawelbaran
Copy link
Member

Dispensating the unit test check as this PR does not introduce any new failures compared to develop (e.g. here).

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving on the basis of previous approval by @jtrainor1 - the code has only been rebased since then.

@pawelbaran
Copy link
Member

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 27566220787

Copy link

bhombot-ci bot commented Jul 17, 2024

@pawelbaran I have now provided a passing check on reference 27566220787 as requested.

@pawelbaran
Copy link
Member

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jul 17, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

@pawelbaran pawelbaran merged commit b7b0b35 into develop Jul 17, 2024
13 checks passed
@pawelbaran pawelbaran deleted the Ground_Engine-#3271-#ConsolidateMethodForStrata branch July 17, 2024 15:12
@BHoMBot BHoMBot mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ground_Engine: Consolidate Stratum objects when they repeat
3 participants