-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ground_Engine: Consolidate method for a Borehole #3372
Ground_Engine: Consolidate method for a Borehole #3372
Conversation
@BHoMBot check compliance |
@peterjamesnugent to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Component manages to combine the AGS data correctly.
@BHoMBot check unit-tests |
@peterjamesnugent to confirm, the following actions are now queued:
|
@BHoMBot check unit-tests |
@pawelbaran to confirm, the following actions are now queued:
|
@BHoMBot check copyright-compliance |
@pawelbaran to confirm, the following actions are now queued:
|
@BHoMBot check unit-tests |
@pawelbaran to confirm, the following actions are now queued:
|
cd6a610
to
3329a92
Compare
@BHoMBot check unit-tests |
@pawelbaran to confirm, the following actions are now queued:
|
@BHoMBot check unit-tests |
@pawelbaran to confirm, the following actions are now queued:
|
@BHoMBot check unit-tests |
@pawelbaran to confirm, the following actions are now queued:
|
@BHoMBot check compliance |
@pawelbaran to confirm, the following actions are now queued:
There are 6 requests in the queue ahead of you. |
@pawelbaran to confirm, the following actions are now queued:
There are 3 requests in the queue ahead of you. |
@pawelbaran to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
FAO: @FraserGreenroyd The check they wish to have dispensation on is unit-tests. If you are providing dispensation on this occasion, please reply with:
|
Dispensating the unit test check as this PR does not introduce any new failures compared to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving on the basis of previous approval by @jtrainor1 - the code has only been rebased since then.
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 27566220787 |
@pawelbaran I have now provided a passing check on reference |
@BHoMBot check ready-to-merge |
@pawelbaran to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #3271
Test files
https://burohappold.sharepoint.com/:u:/s/BHoM/Ed88wg7PXYJEmTkOJcxKgkgBDI2rWoJoVNS3sJPTk4iwJw?e=24SqQ2
Changelog
ConsolidateStrata
method that uses a property to combine sequentialStratum
. For example, combiningStratum
with the sameObservedGeology
property.Additional comments