-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geometry_Engine: Tolerance introduced to the check of 2-dimensionality of the input point set #3293
Geometry_Engine: Tolerance introduced to the check of 2-dimensionality of the input point set #3293
Conversation
@BHoMBot check compliance |
@pawelbaran to confirm, the following actions are now queued:
|
@BHoMBot check required |
@pawelbaran to confirm, the following actions are now queued:
There are 23 requests in the queue ahead of you. |
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with the test script, and that it works as expected. Very clear and easy to follow.
Would it be worth adding an error message if we are going to return null?
Thanks @peterjamesnugent!
Concerning the above question, I would rather not do that because e.g. |
Co-authored-by: Peter Nugent <Peter.Nugent@burohappold.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy changes have been implementd and code is unchanged.
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 9 requests in the queue ahead of you. |
@BHoMBot check required |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
The check |
The check |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 6 requests in the queue ahead of you. |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
Issues addressed by this PR
Closes #3288
Test files
On SharePoint
Changelog
Additional comments