Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry_Engine: split at self intersections method added #3292

Merged
merged 4 commits into from
Feb 26, 2024

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Feb 23, 2024

Issues addressed by this PR

Closes #3291

Test files

On SharePoint.

Changelog

Additional comments

@pawelbaran pawelbaran added the type:feature New capability or enhancement label Feb 23, 2024
@pawelbaran pawelbaran self-assigned this Feb 23, 2024
@pawelbaran
Copy link
Member Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Feb 25, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 7 requests in the queue ahead of you.

@pawelbaran
Copy link
Member Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Feb 25, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 37 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Feb 25, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Feb 25, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

vietle-bh
vietle-bh previously approved these changes Feb 26, 2024
Copy link
Contributor

@vietle-bh vietle-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works great both in the test script and in a tool I'm building!

@pawelbaran
Copy link
Member Author

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Feb 26, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check unit-tests

Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the test script, msall changes to descriptions.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Peter Nugent <Peter.Nugent@burohappold.com>
Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy my comments have been addressed without any changes to the method itself.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Feb 26, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core, installer, null-handling, serialisation, versioning, unit-tests, ready-to-merge

Copy link

bhombot-ci bot commented Feb 26, 2024

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link
Contributor

I have dispensated the checks as they had passed prior to the final change which was documentation only.

@FraserGreenroyd FraserGreenroyd merged commit 0eac638 into develop Feb 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geometry_Engine: add SplitSelfIntersecting(Polyline) method
4 participants