-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analytical_Engine: Fix Querying geometry of Panel #3237
Analytical_Engine: Fix Querying geometry of Panel #3237
Conversation
@Tom-Kingstone to confirm, the following actions are now queued:
There are 34 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the code, makes sense with the switch based on the comments and discussion today on this topic with @Tom-Kingstone @adecler and others on the historic issue review call.
@FraserGreenroyd to confirm, the following actions are now queued:
There are 30 requests in the queue ahead of you. |
@BHoMBot check versioning |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 40 requests in the queue ahead of you. |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests, installer |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
@BHoMBot this is a DevOps instruction. I am granting dispensation to be granted on check ref. 20395350862 |
@FraserGreenroyd I'm sorry, but I am not authorised to take that instruction from you. |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 31 requests in the queue ahead of you. |
FAO: @FraserGreenroyd The check they wish to have dispensation on is ready-to-merge. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 20395650118 |
@FraserGreenroyd I have now provided a passing check on reference |
NOTE: Depends on
Issues addressed by this PR
Closes #2363
Querying the geometry of an IPanel<IEdge, IOpening> now can no longer produce a non-planar PlanarSurface if the Panel in question is non-planar.
Test files
#2356 -IsPlanar-PlanarSurface.zip
Changelog
Additional comments