Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytical_Engine: Fix Querying geometry of Panel #3237

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

Tom-Kingstone
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #2363

Querying the geometry of an IPanel<IEdge, IOpening> now can no longer produce a non-planar PlanarSurface if the Panel in question is non-planar.

Test files

#2356 -IsPlanar-PlanarSurface.zip

Changelog

Additional comments

@Tom-Kingstone Tom-Kingstone added the type:bug Error or unexpected behaviour label Jan 11, 2024
@Tom-Kingstone Tom-Kingstone self-assigned this Jan 11, 2024
@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jan 11, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 34 requests in the queue ahead of you.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code, makes sense with the switch based on the comments and discussion today on this topic with @Tom-Kingstone @adecler and others on the historic issue review call.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check serialisation
@BHoMBot check null-handling

Copy link

bhombot-ci bot commented Jan 11, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check serialisation
  • check null-handling

There are 30 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Jan 11, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

There are 40 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests, installer

Copy link

bhombot-ci bot commented Jan 11, 2024

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am granting dispensation to be granted on check ref. 20395350862

Copy link

bhombot-ci bot commented Jan 11, 2024

@FraserGreenroyd I'm sorry, but I am not authorised to take that instruction from you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jan 11, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 31 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Jan 11, 2024

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is ready-to-merge.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 20395650118

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 20395650118

Copy link

bhombot-ci bot commented Jan 11, 2024

@FraserGreenroyd I have now provided a passing check on reference 20395650118 as requested.

@FraserGreenroyd FraserGreenroyd merged commit 0b98a8b into develop Jan 11, 2024
@FraserGreenroyd FraserGreenroyd deleted the Analytical_Engine-#2363-PlanarSurfaceFix branch January 11, 2024 17:32
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analysis_Engine: Query.Geometry() method allows you to generate a non planar PlanarSurface
2 participants