Geometry_Engine: redundant calls to clone removed

[pawelbaran]

Issues addressed by this PR

Closes #943

Test files

@FraserGreenroyd as discussed, it would be great if you could do a sanity check and onboard someone to dust off the test scripts that would confirm that I have not broken anything 🙈

Changelog

Additional comments

[Tom-Kingstone]

@BHoMBot check unit-tests

[bhombot-ci]

@Tom-Kingstone to confirm, the following actions are now queued:

• check unit-tests

[Tom-Kingstone]

Tested by running all the unit tests for Geometry_Engine, and came back with 3 errors, see below:

[pawelbaran]

Thanks @Tom-Kingstone for testing, I pushed a fix for the bug that you have found 👍

[Tom-Kingstone]

@BHoMBot check unit-tests

[bhombot-ci]

@Tom-Kingstone to confirm, the following actions are now queued:

• check unit-tests

[Tom-Kingstone]

After testing with Geometry_Engine unit tests locally, as well as some other engines that are dependent on the Geometry_Engine (namely environment, facade and physical), I am happy to say that removing DeepClone in these places does not break the methods.

[FraserGreenroyd]

Have reviewed the code and @Tom-Kingstone has run the tests so this looks good to me now 😄

[FraserGreenroyd]

@BHoMBot check versioning
@BHoMBot check installer
@BHoMBot check compliance
@BHoMBot check required

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check versioning
• check installer
• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance
• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

[bhombot-ci]

Please be advised that the check with reference 20335594460 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 57 additional annotations waiting, made up of 0 errors and 57 warnings.

[bhombot-ci]

Please be advised that the check with reference 20335605755 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 130 additional annotations waiting, made up of 0 errors and 130 warnings.

[bhombot-ci]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

Please be advised that the check with reference 20335635243 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 130 additional annotations waiting, made up of 0 errors and 130 warnings.

[bhombot-ci]

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

[FraserGreenroyd]

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core, documentation-compliance, null-handling, serialisation, unit-tests

[bhombot-ci]

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

[FraserGreenroyd]

@BHoMBot check ready-to-merge

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check ready-to-merge