Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment_Engine: Update AssignSpaceTypeByPoint to provide output of spaces not assigned #3180

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

FraserGreenroyd
Copy link
Contributor

Fixes #3179

@FraserGreenroyd FraserGreenroyd added the type:user-experience Issues and changes relating to improving the overall User Experience (UX) of the tools label Sep 11, 2023
@FraserGreenroyd FraserGreenroyd self-assigned this Sep 11, 2023
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 11, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

Copy link
Contributor

@Tom-Kingstone Tom-Kingstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through with Fraser in pair programming session, and works properly as set out.

@Tom-Kingstone
Copy link
Contributor

@BHoMBot check required
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 11, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer
  • check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 11, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 11, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: installer, unit-tests, ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 11, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit dcc3618 into develop Sep 11, 2023
@FraserGreenroyd FraserGreenroyd deleted the Environment_Engine-#3179-AssignSpaceType branch September 11, 2023 17:03
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:user-experience Issues and changes relating to improving the overall User Experience (UX) of the tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment_Engine: Assign space type by point not returning elements not assigned
2 participants