Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment_Engine: Renaming input in the Transform.cs #3124

Merged

Conversation

kprusicka
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #3123

Input in the Transform.cs method was renamed from 'transform' to 'matrix'

Test files

Changelog

Additional comments

@FraserGreenroyd FraserGreenroyd added the type:documentation Wiki, help or in code attributes label Aug 1, 2023
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 1, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 1 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd changed the title Renaming input in the Transform.cs Environment_Engine: Renaming input in the Transform.cs Aug 1, 2023
@bhombot-ci
Copy link

bhombot-ci bot commented Aug 1, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 1, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 1, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on code review, variable renamed and versioning added after initial review for the PreviousInputNames so happy to deploy.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 1, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 32fc789 into develop Aug 1, 2023
@FraserGreenroyd FraserGreenroyd deleted the Environment_Engine-#3123-RenamingTransformInput branch August 1, 2023 10:18
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation Wiki, help or in code attributes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment_Engine Renaming Transform.cs input from 'transform' to 'matrix'
2 participants