-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geometry_Engine: Add methods to assist with tagging workflows #3102
Conversation
@vietle-bh to confirm, the following actions are now queued:
There are 8 requests in the queue ahead of you. |
@vietle-bh to confirm, the following actions are now queued:
There are 40 requests in the queue ahead of you. |
@BHoMBot check unit-tests |
@vietle-bh to confirm, the following actions are now queued:
|
64af09c
to
0b17eb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the code, only a few minor tweaks suggested. However, please be so kind and provide a Grasshopper test script with the added methods - you are touching core projects of the entire BHoM here so extensive testing is a must. The script should ensure correctness of the methods as it will be serialised to serve as a unit test in the future.
@vietle-bh to confirm, the following actions are now queued:
|
@vietle-bh to confirm, the following actions are now queued:
|
@BHoMBot check unit-tests |
@vietle-bh to confirm, the following actions are now queued:
There are 5 requests in the queue ahead of you. |
@pawelbaran , I've added the GH test script to this PR's description. |
@vietle-bh I have had a look at the test script you prepared - it is a good start, but definitely not sufficient (not enough cases, no verification). I quickly patched up an alternative how I would do it and uploaded it here. Let's have a chat tomorrow to coordinate on how to bring this PR over the line 💪 |
@BHoMBot check unit-tests |
@pawelbaran to confirm, the following actions are now queued:
There are 28 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to approve the PR following the code review, testing and unit test creation done together with @vietle-bh 👍 Good stuff!
@BHoMBot check required |
@vietle-bh to confirm, the following actions are now queued:
|
@BHoMBot check versioning |
@vietle-bh to confirm, the following actions are now queued:
There are 19 requests in the queue ahead of you. |
Sorry @FraserGreenroyd , similar story here where the failed test isn't relevant to this PR. It's the unit-tests this time. Could we bypass this please? |
32c6fa3
to
6ab5caf
Compare
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@FraserGreenroyd to confirm, the following actions are now queued:
|
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: ready-to-merge, unit-tests |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
NOTE: This is #3035 reopened.
Issues addressed by this PR
Closes #3033, Closes #3034
Added new methods such as:
Test files
Test_script.zip
Changelog
Added engine methods for new use cases.
Additional comments