-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialiser_Engine: Remove the 'failed' bool parameter in the deserialiser methods #3089
Serialiser_Engine: Remove the 'failed' bool parameter in the deserialiser methods #3089
Conversation
@BHoMBot check versioning |
@adecler to confirm, the following actions are now queued:
|
@BHoMBot check compliance |
@adecler to confirm, the following actions are now queued:
|
@BHoMBot check serialisation |
@adecler to confirm, the following actions are now queued:
|
@FraserGreenroyd to confirm, the following actions are now queued:
There are 17 requests in the queue ahead of you. |
FAO: @FraserGreenroyd The check they wish to have dispensation on is unit-tests. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 14291210363 |
@FraserGreenroyd I have now provided a passing check on reference |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is deleted, checks pass, spot check on a couple of objects in Grasshopper, all looks good, happy to deploy.
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #3087
Parameter removed from all methods as it wasn't used anymore and its purpose could be misunderstood.
Test files
Just make sure that all objects are still (de)serialising correctly.
@FraserGreenroyd , I'll leave it to you to decide how much testing you need on this PR. Since this PR doesn't actually change the behaviour of the serialiser, I am pretty relax about it.
Changelog
Additional comments