Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialiser_Engine: Remove the 'failed' bool parameter in the deserialiser methods #3089

Merged

Conversation

adecler
Copy link
Member

@adecler adecler commented Jun 15, 2023

Issues addressed by this PR

Closes #3087

Parameter removed from all methods as it wasn't used anymore and its purpose could be misunderstood.

Test files

Just make sure that all objects are still (de)serialising correctly.
@FraserGreenroyd , I'll leave it to you to decide how much testing you need on this PR. Since this PR doesn't actually change the behaviour of the serialiser, I am pretty relax about it.

Changelog

Additional comments

@adecler adecler added the type:compliance Non-conforming to code guidelines label Jun 15, 2023
@adecler adecler requested a review from FraserGreenroyd as a code owner June 15, 2023 08:37
@adecler adecler self-assigned this Jun 15, 2023
@adecler
Copy link
Member Author

adecler commented Jun 15, 2023

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 15, 2023

@adecler to confirm, the following actions are now queued:

  • check versioning

@adecler
Copy link
Member Author

adecler commented Jun 15, 2023

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 15, 2023

@adecler to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@adecler
Copy link
Member Author

adecler commented Jun 15, 2023

@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 15, 2023

@adecler to confirm, the following actions are now queued:

  • check serialisation

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check unit-tests
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 15, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check unit-tests
  • check installer

There are 17 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 15, 2023

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is unit-tests.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 14291210363

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 14291210363

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 15, 2023

@FraserGreenroyd I have now provided a passing check on reference 14291210363 as requested.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is deleted, checks pass, spot check on a couple of objects in Grasshopper, all looks good, happy to deploy.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 15, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 750237b into develop Jun 15, 2023
@FraserGreenroyd FraserGreenroyd deleted the Serialiser_Engine-#3087-RemoveFailedParameter branch June 15, 2023 13:52
@FraserGreenroyd FraserGreenroyd changed the title Remove the 'failed' bool parameter in the deserialiser methods Serialiser_Engine: Remove the 'failed' bool parameter in the deserialiser methods Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serialiser_Engine: remove the 'failed' bool parameter in the deserialiser methods
2 participants