-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diffing_Engine: reworked the NumericTolerance mechanism #3040
Diffing_Engine: reworked the NumericTolerance mechanism #3040
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I missed to update the older tests to the new mechanism. I'd post comments on the Tests in the DiffingTests_Prototypes PR, until I manage to port the tests from there to the |
@BHoMBot check required |
@pawelbaran to confirm, the following actions are now queued:
There are 20 requests in the queue ahead of you. |
1046e11
to
07624f8
Compare
@BHoMBot check core |
@alelom to confirm, the following actions are now queued:
|
@BHoMBot check required |
@alelom to confirm, the following actions are now queued:
|
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests passed, also successfully tested on actual sample problems.
@BHoMBot check ready-to-merge |
@pawelbaran to confirm, the following actions are now queued:
There are 16 requests in the queue ahead of you. |
@pawelbaran to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #3039
Reworked the NumericalTolerance mechanism to compute the difference between the numbers, then see if it is larger than the specified tolerance.
Test files
See #3039.
Additional comments