Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diffing_Engine: reworked the NumericTolerance mechanism #3040

Merged

Conversation

alelom
Copy link
Member

@alelom alelom commented Apr 13, 2023

Issues addressed by this PR

Closes #3039

Reworked the NumericalTolerance mechanism to compute the difference between the numbers, then see if it is larger than the specified tolerance.

Test files

See #3039.

Additional comments

@alelom alelom added the type:bug Error or unexpected behaviour label Apr 13, 2023
@alelom alelom requested a review from pawelbaran April 13, 2023 14:40
@alelom alelom self-assigned this Apr 13, 2023
@alelom alelom changed the title Update NumericalDifferenceInclusion.cs Diffing_Engine: reworked the NumericTolerance mechanism Apr 13, 2023
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes make sense to me, but I am getting errors in tests:

image

@alelom
Copy link
Member Author

alelom commented Apr 14, 2023

Code changes make sense to me, but I am getting errors in tests

Thanks, I missed to update the older tests to the new mechanism. I'd post comments on the Tests in the DiffingTests_Prototypes PR, until I manage to port the tests from there to the .ci folder in the BHoM_Engine. See the DiffingTests PR: BHoM/DiffingTests_Prototypes#12

@pawelbaran
Copy link
Member

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 17, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 20 requests in the queue ahead of you.

@alelom alelom force-pushed the Diffing_Engine-#3039-reworkedToleranceApproximation branch from 1046e11 to 07624f8 Compare April 17, 2023 11:43
@alelom
Copy link
Member Author

alelom commented Apr 17, 2023

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 17, 2023

@alelom to confirm, the following actions are now queued:

  • check core

@alelom
Copy link
Member Author

alelom commented Apr 17, 2023

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 17, 2023

@alelom to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 17, 2023

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests passed, also successfully tested on actual sample problems.

@pawelbaran
Copy link
Member

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 17, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

There are 16 requests in the queue ahead of you.

@pawelbaran
Copy link
Member

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 17, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check unit-tests

@pawelbaran pawelbaran merged commit 27983e8 into develop Apr 17, 2023
@pawelbaran pawelbaran deleted the Diffing_Engine-#3039-reworkedToleranceApproximation branch April 17, 2023 15:17
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diffing_Engine: implementation of NumericalDifferenceInclusion Tolerance approximation to be reviewed
2 participants