Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEP_Engine: MEP Psychrometric Equations Unit and Descriptions Updated #3024

Merged

Conversation

travispotterBH
Copy link

NOTE: Depends on

Issues addressed by this PR

Closes #3023

  • Units updated

Test files

Changelog

Additional comments

@travispotterBH travispotterBH added the type:bug Error or unexpected behaviour label Mar 15, 2023
@travispotterBH travispotterBH self-assigned this Mar 15, 2023
@travispotterBH travispotterBH mentioned this pull request Mar 15, 2023
Copy link
Contributor

@alexissantella alexissantella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved based on code review, all looks good to me

@travispotterBH
Copy link
Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 16, 2023

@travispotterBH to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 66 requests in the queue ahead of you.

@travispotterBH
Copy link
Author

@BHoMBot check core
@BHoMBot check compliance
@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 17, 2023

@travispotterBH to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 17, 2023

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 17, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 17, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning
@BHoMBot check installer
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 18, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning
  • check installer
  • check ready-to-merge

There are 27 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 7cfc9be into develop Mar 18, 2023
@FraserGreenroyd FraserGreenroyd deleted the MEP_Engine-#3023-IncorrectUnitsAndDescriptions branch March 18, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MEP_Engine: Incorrect units and descriptions
3 participants