Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHoM_Engine: IToText fixed for primitives and DateTime #3020

Merged
merged 2 commits into from
Mar 18, 2023

Conversation

pawelbaran
Copy link
Member

Issues addressed by this PR

Closes #3019

Test files

On SharePoint

Changelog

Additional comments

@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label Mar 15, 2023
@pawelbaran pawelbaran self-assigned this Mar 15, 2023
@pawelbaran
Copy link
Member Author

@BHoMBot check core
@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 15, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 15 requests in the queue ahead of you.

Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change makes sense and works well in GH:

image

@pawelbaran
Copy link
Member Author

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 15, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check unit-tests

Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I forgot to test one type and that's the one not working anymore:

image

@pawelbaran pawelbaran requested a review from adecler March 15, 2023 11:26
@pawelbaran
Copy link
Member Author

@BHoMBot check core
@BHoMBot check compliance
@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 15, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check unit-tests

There are 18 requests in the queue ahead of you.

Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now:
image

@pawelbaran
Copy link
Member Author

@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 15, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check null-handling
  • check serialisation
  • check versioning

@pawelbaran
Copy link
Member Author

@BHoMBot check versioning
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 15, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check versioning
  • check installer

There are 12 requests in the queue ahead of you.

@adecler
Copy link
Member

adecler commented Mar 16, 2023

@BHoMBot check ready-to-merge

1 similar comment
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 18, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 4 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 618ebeb into develop Mar 18, 2023
@FraserGreenroyd FraserGreenroyd deleted the Excel_Toolkit-#14-EnumValueBug branch March 18, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BHoM_Engine: IToText returns nonsensical values for primitives and DateTime
3 participants