Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment_Engine: opening split bug fixed #3004

Merged
merged 2 commits into from
Feb 10, 2023

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Feb 9, 2023

Issues addressed by this PR

Closes #2969

Test files

On SharePoint

Changelog

Additional comments

@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label Feb 9, 2023
@pawelbaran pawelbaran requested a review from kprusicka February 9, 2023 16:42
@pawelbaran pawelbaran self-assigned this Feb 9, 2023
Copy link
Contributor

@kprusicka kprusicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code and tested in grasshopper, method returns spitted curves correctly.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, tests work well, happy to deploy.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 10, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 10, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation
  • check unit-tests

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 10, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 10, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 10, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit aff0ad7 into develop Feb 10, 2023
@FraserGreenroyd FraserGreenroyd deleted the Environment_Engine-#2969-SplitOpeningFix branch February 10, 2023 18:23
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment_Engine: SplitOpeningByGeometry method bug
3 participants