Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflection_Engine: Add method to query the documentation URLs for a given MemberInfo #3002

Merged
merged 5 commits into from
Feb 6, 2023

Conversation

FraserGreenroyd
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd commented Feb 6, 2023

NOTE: Depends on

BHoM/BHoM#1472

Issues addressed by this PR

Fixes #471

Test files

Reflection_Engine - DocumentationURL.zip

Changelog

Additional comments

@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Feb 6, 2023
@FraserGreenroyd FraserGreenroyd self-assigned this Feb 6, 2023
@BHoMBot BHoMBot requested a review from rwemay as a code owner February 6, 2023 14:49
@FraserGreenroyd FraserGreenroyd removed the request for review from rwemay February 6, 2023 14:49
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 6, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 6, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 6, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

alelom
alelom previously approved these changes Feb 6, 2023
Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on code and test script.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 6, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check null-handling

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 6, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check serialisation
@BHoMBot check unit-tests
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 6, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check serialisation
  • check unit-tests
  • check ready-to-merge

There are 5 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 6, 2023

@FraserGreenroyd just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 6, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 6, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check unit-tests

alelom
alelom previously approved these changes Feb 6, 2023
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 6, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 6, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: versioning, installer, core, serialisation, null-handling, ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 6, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 49a3d31 into develop Feb 6, 2023
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Engine-#471-DocumentationAttribute branch February 6, 2023 18:17
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reflection_Engine: Add an optional link to Wiki as a method attribute
2 participants