Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure_Engine: Align with migration of Structures datasets to subfolder #2980

Merged

Conversation

IsakNaslundBh
Copy link
Contributor

NOTE: Depends on

BHoM/BHoM_Datasets#122

Issues addressed by this PR

Aligns hardcoded paths to datasets migrated to discipline superfolder.

Test files

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:external-api-changes Imposed changes, including from dependency across other BHoM repos label Jan 5, 2023
@IsakNaslundBh IsakNaslundBh requested a review from rwemay as a code owner January 5, 2023 10:21
@IsakNaslundBh IsakNaslundBh self-assigned this Jan 5, 2023
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes reviewed only, looks aligned per discussion with @IsakNaslundBh

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2023

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM_Datasets

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 6 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2023

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 6, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check unit-tests

There are 5 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 6, 2023

@IsakNaslundBh just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Datasets

@IsakNaslundBh IsakNaslundBh merged commit 064ceb2 into develop Jan 6, 2023
@IsakNaslundBh IsakNaslundBh deleted the BHoM_Dataset-#121-AlignDatasetFolderWithNamespace branch January 6, 2023 11:57
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants