Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.ci - Remove unit test that is poorly designed #2978

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

FraserGreenroyd
Copy link
Contributor

Removes the ToJson unit test which was poorly designed to account for version changes.

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Jan 4, 2023
@FraserGreenroyd FraserGreenroyd self-assigned this Jan 4, 2023
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 4, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core, code-compliance, copyright-compliance, dataset-compliance, documentation-compliance, installer, null-handling, project-compliance, ready-to-merge, serialisation, versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 4, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this to be removed given this is fully checked by Check serialisation which should more all encompassing.

@FraserGreenroyd FraserGreenroyd merged commit c997170 into develop Jan 4, 2023
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Engine-#01-RemoveFailingUnitTest branch January 4, 2023 13:45
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants