-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MEP_Engine: Add HVAC Heat Equations #2967
MEP_Engine: Add HVAC Heat Equations #2967
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the comments, I'm not sure on the use of AirSide
and WaterSide
as sub-folders. Are we expecting many calculations for each type? Are there any other types of side
we're not yet building up?
If we are needing AirSide
and WaterSide
, then we should have it match that in the namespace too which it doesn't currently.
I could be swayed to different terminology. Wanting mostly to differentiate between equations that assume air as the process fluid vs those that assume water. |
Co-authored-by: Fraser Greenroyd <fraser.greenroyd@burohappold.com>
@alexissantella I generalized the equations. They work for both air and water, if they user supplies the proper specific heat and and fluid density values. |
Added Unit Tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed equations for accuracy. It looks good to me.
@BHoMBot check required |
@travispotterBH to confirm, the following actions are now queued:
|
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check unit-tests |
@FraserGreenroyd to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comments have been address, @alexissantella is happy so this is all good to go.
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
0056532
@BHoMBot check unit-tests |
@travispotterBH to confirm, the following actions are now queued:
There are 27 requests in the queue ahead of you. |
@BHoMBot check required |
@travispotterBH to confirm, the following actions are now queued:
|
The check |
@travispotterBH to confirm, the following actions are now queued:
There are 11 requests in the queue ahead of you. |
@BHoMBot check copyright-compliance |
@travispotterBH to confirm, the following actions are now queued:
There are 18 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-approval for fixed unit tests. Looks good!
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
Issues addressed by this PR
Closes #2737
Test files
Changelog
Compute.ProcessSensibleHeat
- Added processes sensible heat calculationCompute.ProcessLatentHeat
- Added processes latent heat calculationCompute.ProcessTotalHeat
- Added processes total heat calculationCompute.MassFlowRate
- Added mass flow rate calculation calculationAdditional comments