-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Facade_Engine: Update Methods to Handle UValueContinuous Fragment #2906
Facade_Engine: Update Methods to Handle UValueContinuous Fragment #2906
Conversation
Allows panel with UValueFrame to continue calculations
Fixed area weighting calc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested the new and altered methods with a variety of openings and panels, including both valid and invalid objects. Result U Values were accurate against manual checks, and errors were clear for the user when invalid objects were used.
@BHoMBot check required |
@BHoMBot check compliance |
@enarhi to confirm, the following actions are now queued:
|
@BHoMBot check required |
@enarhi to confirm, the following actions are now queued:
|
The check |
The check |
@enarhi to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #2905
Test files
Test File