Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facade_Engine: Update Methods to Handle UValueContinuous Fragment #2906

Merged

Conversation

vgreen-BH
Copy link
Contributor

@vgreen-BH vgreen-BH commented Sep 7, 2022

Issues addressed by this PR

Closes #2905

  • Updated UValueOpeningAW method to handle construction fragment UValueContinuous
  • Created new method UValuePanelAW that calculates the u-value of a panel by area weighting the UValueContinuous assigned to panel construction and the u-values of all Openings within the panel

Test files

Test File

Fixed effectiveUValue and contUValue variables
Allows panel with UValueFrame to continue calculations
@vgreen-BH vgreen-BH added the type:feature New capability or enhancement label Sep 7, 2022
@vgreen-BH vgreen-BH added this to the BHoM 5.3 β MVP milestone Sep 7, 2022
@vgreen-BH vgreen-BH requested a review from enarhi September 7, 2022 04:31
@vgreen-BH vgreen-BH self-assigned this Sep 7, 2022
@vgreen-BH vgreen-BH changed the title Facade engine #2905 update methodsfor u value continuous Facade_Engine: Update Methods to Handle UValueContinuous Fragment Sep 7, 2022
Copy link
Member

@enarhi enarhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested the new and altered methods with a variety of openings and panels, including both valid and invalid objects. Result U Values were accurate against manual checks, and errors were clear for the user when invalid objects were used.

@enarhi
Copy link
Member

enarhi commented Sep 7, 2022

@BHoMBot check required

@enarhi
Copy link
Member

enarhi commented Sep 7, 2022

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 7, 2022

@enarhi to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@enarhi
Copy link
Member

enarhi commented Sep 7, 2022

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 7, 2022

@enarhi to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 7, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 7, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@enarhi
Copy link
Member

enarhi commented Sep 7, 2022

@BHoMBot check ready-to-merge
@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 7, 2022

@enarhi to confirm, the following actions are now queued:

  • check ready-to-merge
  • check unit-tests

@IsakNaslundBh IsakNaslundBh merged commit e615b51 into main Sep 8, 2022
@IsakNaslundBh IsakNaslundBh deleted the Facade_Engine-#2905-UpdateMethodsforUValueContinuous branch September 8, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facade_Engine: Add Methods to use UValueContinuous for Panels and Openings
3 participants