Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spatial_Engine: bounding box query for profiles added #2884

Merged
merged 2 commits into from
Jul 15, 2022

Conversation

pawelbaran
Copy link
Member

Issues addressed by this PR

Closes #

Test files

Implicitly tested by BHoM/Revit_Toolkit#1225

Changelog

Additional comments

@JosefTaylor
Copy link
Contributor

I wonder if this can be used for Extrude(Bar) as it's currently computing the bounds of the edge curves of a section for 'simple' extrusions. Good to have more generalized extension methods!

@pawelbaran
Copy link
Member Author

Fair point @JosefTaylor - I have looked up Extrude method and the stuff that I am just adding should be applicable to it. However, I would rather do that in a separate PR not to inflate the scope of this PR. Happy to raise an issue once this one gets approved 👍

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 14, 2022

@pawelbaran just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on Revit_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 14, 2022

@pawelbaran just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on Revit_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 15, 2022

@pawelbaran just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on Revit_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 15, 2022

@pawelbaran just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on Revit_Toolkit

@pawelbaran
Copy link
Member Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 15, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@pawelbaran
Copy link
Member Author

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 15, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation

There are 7 requests in the queue ahead of you.

@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 15, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

There are 18 requests in the queue ahead of you.

@pawelbaran pawelbaran merged commit 59979ee into main Jul 15, 2022
@pawelbaran pawelbaran deleted the Revit_Toolkit-#1221-RevitProfileGenerator branch July 15, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants