Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Architecture_Engine: Remove CleanRoom, version to use CleanRegion #2880

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Architecture_Engine: Remove CleanRoom, version to use CleanRegion #2880

merged 1 commit into from
Jul 5, 2022

Conversation

FraserGreenroyd
Copy link
Contributor

Issues addressed by this PR

Fixes #2849

Test files

Changelog

Additional comments

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Jul 5, 2022
@FraserGreenroyd FraserGreenroyd self-assigned this Jul 5, 2022
@FraserGreenroyd FraserGreenroyd requested a review from adecler as a code owner July 5, 2022 15:11
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 5, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • versioning

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check required
@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 5, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer
  • copyright-compliance
  • dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 5, 2022

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check documentation-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 5, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • documentation-compliance

There are 12 requests in the queue ahead of you.

robinflyman
robinflyman approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@robinflyman robinflyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 5, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit f50543b into main Jul 5, 2022
@FraserGreenroyd FraserGreenroyd deleted the Architecture_Engine-#2849-RemoveCleanRoom branch July 5, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinflyman robinflyman robinflyman approved these changes

@rboulton-BH rboulton-BH Awaiting requested review from rboulton-BH

@emilsvedjer emilsvedjer Awaiting requested review from emilsvedjer

@jamesramsden-bh jamesramsden-bh Awaiting requested review from jamesramsden-bh

Assignees

@FraserGreenroyd FraserGreenroyd

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Architecture_Engine: Remove CleanRoom method
2 participants
@FraserGreenroyd @robinflyman