-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Environment_Engine: Created new methods for IsShade #2793
Environment_Engine: Created new methods for IsShade #2793
Conversation
@BHoMBot check versioning |
@robinflyman to confirm, the following checks are now queued:
There are 26 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the versioning - see my code suggestions.
You need to delete Geometry_Engine/Geometry_Engine - Backup.csproj
and Graphics_Engine/Graphics_Engine - Backup.csproj
and commit the deletions as neither of those files are required.
@BHoMBot check versioning |
@robinflyman to confirm, the following checks are now queued:
|
@BHoMBot check versioning |
@FraserGreenroyd to confirm, the following checks are now queued:
|
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following checks are now queued:
|
@BHoMBot check required |
@FraserGreenroyd to confirm, the following checks are now queued:
There are 2 requests in the queue ahead of you. |
The check |
@FraserGreenroyd to confirm, the following actions are now queued:
|
91a439a
to
ea129ae
Compare
@FraserGreenroyd to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
@BHoMBot check versioning |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 3 requests in the queue ahead of you. |
@BHoMBot check installer |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
@BHoMBot check required |
@FraserGreenroyd to confirm, the following actions are now queued:
|
The check |
The check |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 12 requests in the queue ahead of you. |
FAO: @FraserGreenroyd The check they wish to have dispensation on is null-handling. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 7524112114 |
@FraserGreenroyd I have now provided a passing check on reference |
Closes #2792
Added IsShade methods according to Frasers suggestion.