Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment_Engine: Created new methods for IsShade #2793

Merged
merged 7 commits into from
Jul 26, 2022

Conversation

robinflyman
Copy link
Contributor

Closes #2792

Added IsShade methods according to Frasers suggestion.

@robinflyman robinflyman added size:S Measured in minutes type:compliance Non-conforming to code guidelines labels Apr 20, 2022
@robinflyman robinflyman self-assigned this Apr 20, 2022
@robinflyman
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 20, 2022

@robinflyman to confirm, the following checks are now queued:

  • versioning

There are 26 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd requested review from jamesramsden-bh and removed request for rwemay, al-fisher, adecler, pawelbaran and epignatelli April 20, 2022 15:43
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the versioning - see my code suggestions.

You need to delete Geometry_Engine/Geometry_Engine - Backup.csproj and Graphics_Engine/Graphics_Engine - Backup.csproj and commit the deletions as neither of those files are required.

Environment_Engine/Modify/SetShadePanels.cs Outdated Show resolved Hide resolved
Environment_Engine/Modify/SetShadePanels.cs Outdated Show resolved Hide resolved
Environment_Engine/Modify/SetShadePanels.cs Outdated Show resolved Hide resolved
Environment_Engine/Modify/SetShadePanels.cs Outdated Show resolved Hide resolved
Environment_Engine/Query/IsShade.cs Outdated Show resolved Hide resolved
Environment_Engine/Query/IsShade.cs Outdated Show resolved Hide resolved
Environment_Engine/Query/IsShade.cs Outdated Show resolved Hide resolved
Environment_Engine/Query/IsShade.cs Outdated Show resolved Hide resolved
Environment_Engine/Query/IsShade.cs Outdated Show resolved Hide resolved
Environment_Engine/Query/IsShade.cs Outdated Show resolved Hide resolved
@robinflyman
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 21, 2022

@robinflyman to confirm, the following checks are now queued:

  • versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 25, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 26, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 26, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 2 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 26, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 25, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning
  • check installer

@FraserGreenroyd FraserGreenroyd force-pushed the Environment_Engine-#2792-CreateIsShadeMethod branch from 91a439a to ea129ae Compare July 26, 2022 10:18
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 26, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning
  • check installer

There are 2 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 26, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

There are 3 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 26, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

There are 2 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 26, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 26, 2022

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 26, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 26, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check ready-to-merge

There are 12 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 26, 2022

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is null-handling.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 7524112114

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 7524112114

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 26, 2022

@FraserGreenroyd I have now provided a passing check on reference 7524112114 as requested.

@FraserGreenroyd FraserGreenroyd merged commit 10bb996 into main Jul 26, 2022
@FraserGreenroyd FraserGreenroyd deleted the Environment_Engine-#2792-CreateIsShadeMethod branch July 26, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S Measured in minutes type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment_Engine: References to PanelType.Shade should include TranslucentShade
3 participants