Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structure_Engine: Add more unittests #2618

Merged
merged 7 commits into from
Jan 4, 2023
Merged

Structure_Engine: Add more unittests #2618

merged 7 commits into from
Jan 4, 2023

Conversation

IsakNaslundBh
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #

Test files

Changelog

Additional comments

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 13, 2021

@IsakNaslundBh to confirm, the following checks are now queued:

  • unit-tests

@IsakNaslundBh IsakNaslundBh changed the title Structure engine #550 add more q uery unit tests Structure_Engine: Add more unittests Sep 13, 2021
@IsakNaslundBh IsakNaslundBh changed the base branch from main to develop January 3, 2023 09:20
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 3, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check unit-tests

@IsakNaslundBh IsakNaslundBh force-pushed the Structure_Engine-#550-AddMoreQUeryUnitTests branch from 6c8d08b to 9fa7e01 Compare January 4, 2023 11:03
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 4, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check unit-tests

There are 97 requests in the queue ahead of you.

@IsakNaslundBh IsakNaslundBh force-pushed the Structure_Engine-#550-AddMoreQUeryUnitTests branch from 9fa7e01 to 7f40fdf Compare January 4, 2023 13:46
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 4, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check unit-tests

There are 67 requests in the queue ahead of you.

@IsakNaslundBh IsakNaslundBh marked this pull request as ready for review January 4, 2023 14:08
@IsakNaslundBh IsakNaslundBh self-assigned this Jan 4, 2023
@IsakNaslundBh IsakNaslundBh added the type:test-script Creation of unit test required label Jan 4, 2023
@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core, code-compliance, copyright-compliance, dataset-compliance, documentation-compliance, installer, null-handling, project-compliance, ready-to-merge, serialisation, versioning

FraserGreenroyd
FraserGreenroyd approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only adding unit tests which is great, have looked through them with @IsakNaslundBh as code owner and am happy that he's happy with the level of detail included in these tests.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 4, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 93a375d into develop Jan 4, 2023
@FraserGreenroyd FraserGreenroyd deleted the Structure_Engine-#550-AddMoreQUeryUnitTests branch January 4, 2023 14:13
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@al-fisher al-fisher Awaiting requested review from al-fisher al-fisher is a code owner

@rwemay rwemay Awaiting requested review from rwemay rwemay is a code owner

@adecler adecler Awaiting requested review from adecler adecler is a code owner

Assignees

@IsakNaslundBh IsakNaslundBh

Labels
type:test-script Creation of unit test required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IsakNaslundBh @FraserGreenroyd