Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geometry_Engine: BooleanUnion(List<Line>, double, bool) bug in case of multiple overlapping curves #3284

Closed
pawelbaran opened this issue Feb 15, 2024 · 0 comments · Fixed by #3283
Closed

Geometry_Engine: BooleanUnion(List<Line>, double, bool) bug in case of multiple overlapping curves #3284

pawelbaran opened this issue Feb 15, 2024 · 0 comments · Fixed by #3283
Assignees
@pawelbaran
Labels
type:bug Error or unexpected behaviour

Comments

@pawelbaran
Copy link
Member

pawelbaran commented Feb 15, 2024 •
edited
Loading

Description:

In one of real life scenarios I encountered a bug in BooleanUnion(List<Line>, double, bool) method with bool input set to true - it is related to multiple curves starting and ending at almost same points, which makes IncludeIntermediatePointsRanges crash.

Looks like I know how to fix it, so will add it to #3283.

Test file(s):

On SharePoint.
@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label Feb 15, 2024
@pawelbaran pawelbaran self-assigned this Feb 15, 2024
pawelbaran added a commit that referenced this issue Feb 15, 2024
@pawelbaran
#3284 fixed
a802ab3
pawelbaran added a commit that referenced this issue Feb 15, 2024
@pawelbaran
another attempt to fix #3284
e341228
@pawelbaran pawelbaran mentioned this issue Feb 15, 2024
Merged
pawelbaran added a commit that referenced this issue Feb 19, 2024
@pawelbaran
#3284 fixed
9f2e34f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pawelbaran pawelbaran

Labels
type:bug Error or unexpected behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Geometry_Engine: Split bugs fixed and OutlinesFromLines method added BHoM/BHoM_Engine
1 participant
@pawelbaran