Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base_Engine: Centralisation and Standardisation of errors, warnings and notes #1840

Closed
rwemay opened this issue Jun 11, 2020 · 2 comments · Fixed by #3286
Closed

Base_Engine: Centralisation and Standardisation of errors, warnings and notes #1840

rwemay opened this issue Jun 11, 2020 · 2 comments · Fixed by #3286
Assignees
Labels
type:feature New capability or enhancement type:question Ask for further details or start conversation

Comments

@rwemay
Copy link
Member

rwemay commented Jun 11, 2020

Description:

Sorry if this has already been raised elsewhere(!!) Having just made up another warning text, I've been thinking for a while it could be useful to standardise some common warnings into a format - e.g. IsNurbsCurve or IsPlanar, concatenating (or not depending what the format(s) we decide) things like the guid.

@rwemay rwemay added type:feature New capability or enhancement type:question Ask for further details or start conversation labels Jun 11, 2020
@adecler
Copy link
Member

adecler commented Jun 20, 2020

Adding on this issue to broaden the spectrum to a general redesign of the error recording solution.

From the discussion we had in the Monthly Framework Planning Session :

We need to improve the logging system to allow for example to
- silence it
- throw exceptions instead of logging errors when RecordError is called
- be very careful on how the interaction of global settings work on the stack
- also idea of bookmark to delete or recover records since the time of the bookmark
- @alelom to raise issue and draft PR to cover his own user case that triggered the discussion

@alelom , see the change of this PR that was a temporary and bad solution for the problem you raised here about silencing the logging system temporarily. So something that is probably worth mentioning in the issue you raise as both an example of the problem we need to solve and something to fix in the long run once we have a better solution in place.

I would also add that we also mentioned migrating the error log out of Reflection and into the Base namespace.

@adecler
Copy link
Member

adecler commented Jun 20, 2020

See ##1645 for reference to teh migration of some of the reflection engine to the base engine

@adecler adecler changed the title Centralisation and Standardisation of errors, warnings and notes Reflection_Engine: Centralisation and Standardisation of errors, warnings and notes Nov 24, 2020
@alelom alelom changed the title Reflection_Engine: Centralisation and Standardisation of errors, warnings and notes Base_Engine: Centralisation and Standardisation of errors, warnings and notes Feb 20, 2023
FraserGreenroyd pushed a commit that referenced this issue Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement type:question Ask for further details or start conversation
Projects
None yet
5 participants