-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Glazing and FrameEdge Datasets with Material Names and Fixed U-values #128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested both datasets and confirmed presence of new material names as well as updated U values, U Values appear correct and new material names are as expected per the glazing constructions.
@BHoMBot check compliance |
@enarhi to confirm, the following actions are now queued:
|
@BHoMBot check dataset-compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check dataset-compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check dataset-compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: dataset-compliance |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
Issues addressed by this PR
Closes #126
Updates to FrameEdgeProperties and GlazingConstruction datasets. Removed superseded datasets.
FrameEdgeProperties
GlazingConstructions
Test Files
https://burohappold.sharepoint.com/sites/BHoM/02_Current/Forms/AllItems.aspx?csf=1&web=1&e=HlvYHp&cid=ab402372%2D7702%2D48ef%2Db6bc%2D9c3f66547c0a&RootFolder=%2Fsites%2FBHoM%2F02%5FCurrent%2F12%5FScripts%2F03%5FAlpha%2FBHoM%2FBHoM%5FDatasets%2FFacade%20Datasets&FolderCTID=0x0120008122C8891F89054B8ACED0196C70DFC4