Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Glazing and FrameEdge Datasets with Material Names and Fixed U-values #128

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

vgreen-BH
Copy link
Contributor

Issues addressed by this PR

Closes #126

Updates to FrameEdgeProperties and GlazingConstruction datasets. Removed superseded datasets.

FrameEdgeProperties

  • Fixed U-values for operable/fixed window types

GlazingConstructions

  • Added material names for glazing materials
  • Added new IGU types for double IGUs with e-0.05 coating

Test Files

https://burohappold.sharepoint.com/sites/BHoM/02_Current/Forms/AllItems.aspx?csf=1&web=1&e=HlvYHp&cid=ab402372%2D7702%2D48ef%2Db6bc%2D9c3f66547c0a&RootFolder=%2Fsites%2FBHoM%2F02%5FCurrent%2F12%5FScripts%2F03%5FAlpha%2FBHoM%2FBHoM%5FDatasets%2FFacade%20Datasets&FolderCTID=0x0120008122C8891F89054B8ACED0196C70DFC4

@vgreen-BH vgreen-BH added the type:bug Error or unexpected behaviour label Jul 14, 2022
@vgreen-BH vgreen-BH requested a review from enarhi July 14, 2022 18:26
@vgreen-BH vgreen-BH self-assigned this Jul 14, 2022
Copy link
Member

@enarhi enarhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested both datasets and confirmed presence of new material names as well as updated U values, U Values appear correct and new material names are as expected per the glazing constructions.

@enarhi
Copy link
Member

enarhi commented Jul 14, 2022

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 14, 2022

@enarhi to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 15, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check dataset-compliance

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 15, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check dataset-compliance

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 22, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check dataset-compliance

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 22, 2022

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 91f7ce0 into main Jul 22, 2022
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Datasets-#126-FacadeDatasetUpdates branch July 22, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates to Facade Datasets - GlazingConstructions and FrameEdgeProperties
3 participants