Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update compliance #366

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Update compliance #366

merged 1 commit into from
Apr 28, 2023

Conversation

FraserGreenroyd
Copy link
Contributor

Fixes #365

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Apr 27, 2023
@FraserGreenroyd FraserGreenroyd self-assigned this Apr 27, 2023
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 27, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check serialisation

There are 12 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 27, 2023

@FraserGreenroyd just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Apr 27, 2023

@FraserGreenroyd just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 27, 2023

@FraserGreenroyd just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check core
@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 27, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check core
  • check null-handling

There are 51 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 27, 2023

@FraserGreenroyd just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on SQL_Toolkit

IsakNaslundBh
IsakNaslundBh approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve. Change makes sense to me, and we do support HashSet serialisation, which should mean this should be working as intended

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 28, 2023

@FraserGreenroyd just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd FraserGreenroyd merged commit f33789c into develop Apr 28, 2023
@FraserGreenroyd FraserGreenroyd deleted the Base_oM-#1509-IObjectCompliance branch April 28, 2023 14:31
@FraserGreenroyd FraserGreenroyd mentioned this pull request May 4, 2023
Merged
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsakNaslundBh IsakNaslundBh IsakNaslundBh approved these changes

Assignees

@FraserGreenroyd FraserGreenroyd

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IObject compliance
2 participants
@FraserGreenroyd @IsakNaslundBh