Fix distinct causes assigned properties to be lost

[IsakNaslundBh]

Issues addressed by this PR

Closes #126

Finally fixing this old issue of better handling merging of properties on "same" object being pushed in, most common case being highlighted in the issue (Node with and without constraints).

Done by instead of call to Distinct, a call to GroupBy is made, after CopyBHoMProperties and any CopyPropertiesModules is called, making sure all relevant properties are merged over.

Also, update to how the ID assignment from any duplicate objects is made, as simply can rely on the group, rather then trying to re-fetch from the list based on another call with the comparer. This should be a bit more efficient than previous implementation.

Test files

Have added new PushTest doing exactly what is highlighted in the issue. Was failing before, but working after changes.

Also, added a new test to check that all pushed objects have ids assigned. Was working before as well, but wanted to add this additional case as I made some changes to how it was handled.

Changelog

Additional comments

[IsakNaslundBh]

@BHoMBot check compliance

[bhombot-ci]

@IsakNaslundBh to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

[IsakNaslundBh]

@BHoMBot check compliance

[bhombot-ci]

@IsakNaslundBh to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

[IsakNaslundBh]

@BHoMBot check unit-tests

[bhombot-ci]

@IsakNaslundBh to confirm, the following actions are now queued:

• check unit-tests

[IsakNaslundBh]

@BHoMBot check unit-tests

[bhombot-ci]

@IsakNaslundBh to confirm, the following actions are now queued:

• check unit-tests

[IsakNaslundBh]

@BHoMBot check unit-tests

[bhombot-ci]

@IsakNaslundBh to confirm, the following actions are now queued:

• check unit-tests

[IsakNaslundBh]

@BHoMBot check unit-tests

[bhombot-ci]

@IsakNaslundBh to confirm, the following actions are now queued:

• check unit-tests

[alelom]

Approving based on review of code changes and unit-tests. The code changes make sense and effectively fix a problem introduced by the "push at the same time" feature. Unit tests cover this fix well.

[IsakNaslundBh]

@BHoMBot check compliance
@BHoMBot check required

[bhombot-ci]

@IsakNaslundBh to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance
• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

There are 34 requests in the queue ahead of you.

[bhombot-ci]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[FraserGreenroyd]

@BHoMBot check core
@BHoMBot check versioning

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check core
• check versioning

[FraserGreenroyd]

@BHoMBot check versioning

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check versioning

[FraserGreenroyd]

@BHoMBot check serialisation
@BHoMBot check null-handling

[IsakNaslundBh]

@BHoMBot check serialisation
@BHoMBot check null-handling

[FraserGreenroyd]

@BHoMBot check serialisation
@BHoMBot check null-handling

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check serialisation
• check null-handling

[IsakNaslundBh]

@BHoMBot check ready-to-merge

[FraserGreenroyd]

@BHoMBot check ready-to-merge

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check ready-to-merge