-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ProcessObjectsForPush()
to first Unpack any IContainer
, then check for IBHoMObjects
#351
ProcessObjectsForPush()
to first Unpack any IContainer
, then check for IBHoMObjects
#351
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take it as this basically removes a warning for objects of type IContainer
that are not inheriting from BHoMObject
.
Cannot see how this really would have any bad impact on anything.
Code changes makes sense, and all UTs passing.
Happy to approve!
@IsakNaslundBh to confirm, the following actions are now queued:
There are 21 requests in the queue ahead of you. |
@BHoMBot check required |
@alelom to confirm, the following actions are now queued:
There are 38 requests in the queue ahead of you. |
IContainer
is providedIContainer
, then checks for IBHoMObjects
IContainer
, then checks for IBHoMObjectsProcessObjectsForPush()
to first Unpack any IContainer
, then check for IBHoMObjects
@IsakNaslundBh to confirm, the following actions are now queued:
|
The check |
The check |
@BHoMBot check required |
@IsakNaslundBh to confirm, the following actions are now queued:
|
The check |
The check |
@BHoMBot check ready-to-merge |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 40 requests in the queue ahead of you. |
Please be advised that the check with reference 11744447153 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 249 additional annotations waiting, made up of 249 errors and 0 warnings. |
@BHoMBot check versioning |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check installer |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 11 requests in the queue ahead of you. |
@BHoMBot check installer |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 16 requests in the queue ahead of you. |
Issues addressed by this PR
Closes #350
Closes #354
ProcessObjectsForPush()
now first Unpacks anyIContainer
, then checks for IBHoMObjects.This allows to wrap any unpacked non-BHoMObject if required; also, it removes non-relevant warning when an IContainer is provided (as
IContainer
does not implementIBHoMObject
).Test file
See #350