Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add module getting objects with no set ID from loads #330

Merged
merged 12 commits into from
Jan 9, 2023
Merged

Add module getting objects with no set ID from loads #330

merged 12 commits into from
Jan 9, 2023

Conversation

IsakNaslundBh
Copy link
Contributor

Issues addressed by this PR

Closes #329

As mentioned in issue. Dependency module for fetching objects with no ids from loads.

Test files

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label Dec 9, 2022
@IsakNaslundBh IsakNaslundBh self-assigned this Dec 9, 2022
@IsakNaslundBh IsakNaslundBh requested a review from alelom December 9, 2022 11:29
@IsakNaslundBh IsakNaslundBh changed the base branch from main to develop January 3, 2023 09:14
@IsakNaslundBh IsakNaslundBh force-pushed the BHoM_Adapter-#329-AddDependencyModuleForObjectsFreomLoads branch from bb44048 to 598eac7 Compare January 6, 2023 14:56
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 9, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

alelom
alelom approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code now looks good to me. Tested with the provided Tests and with a Push script.

@alelom
Copy link
Member

alelom commented Jan 9, 2023

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 9, 2023

@alelom to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 9, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance
  • check ready-to-merge

There are 12 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd dismissed their stale review January 9, 2023 15:50

Changes were made

@FraserGreenroyd FraserGreenroyd merged commit f61acf7 into develop Jan 9, 2023
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Adapter-#329-AddDependencyModuleForObjectsFreomLoads branch January 9, 2023 15:55
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alelom alelom alelom approved these changes

@FraserGreenroyd FraserGreenroyd Awaiting requested review from FraserGreenroyd

Assignees

@IsakNaslundBh IsakNaslundBh

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Structure_AdapterModules: Add get dependency module for loads only extracting objects with no id set
3 participants
@IsakNaslundBh @FraserGreenroyd @alelom