Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve BHoM Analytics Pop Up Window #38

Merged

Conversation

travispotterBH
Copy link

New PR for branch name compliance: #37

Issues addressed by this PR

Closes #36

Added Branding:
image
@FraserGreenroyd I need help knowing where the image should be placed, and referenced. Will need to ship with installer.
Image below:
BHoM_Logo

Added custom UI for Revit:
BhomAnalytics - Revit version

Revit Self Assign Project Number, when Project Information is set:
BhomAnalytics - Revit Self Assign Project Number

Revit User Assign Project Number, when Project Information is not set:
BhomAnalytics - Revit user Assign Project Number

Added custom UI for Grasshopper:
BhomAnalytics - Grasshopper version

Changelog

  • Improved UX by modifying per UI
  • Allows movable window
  • Includes additional options for non project work
  • Improves UI by including branding

Additional comments

@FraserGreenroyd @al-fisher requested modifications to the installer to update information about logging.
image

BHoMAnalytics_UI/CaptureProjectData.xaml.cs Outdated Show resolved Hide resolved
BHoMAnalytics_UI/CaptureProjectData.xaml.cs Outdated Show resolved Hide resolved
BHoMAnalytics_UI/CaptureProjectData.xaml.cs Outdated Show resolved Hide resolved
BHoMAnalytics_UI/CaptureProjectData.xaml.cs Outdated Show resolved Hide resolved
BHoMAnalytics_UI/CaptureProjectData.xaml.cs Outdated Show resolved Hide resolved
BHoMAnalytics_UI/CaptureProjectData.xaml.cs Outdated Show resolved Hide resolved
BHoMAnalytics_UI/CaptureProjectData.xaml.cs Outdated Show resolved Hide resolved
BHoMAnalytics_oM/Enums/NonProjectOption.cs Outdated Show resolved Hide resolved
BHoMAnalytics_oM/Enums/NonProjectOption.cs Outdated Show resolved Hide resolved
Travis Potter and others added 7 commits September 9, 2022 11:26
Co-authored-by: Fraser Greenroyd <fraser.greenroyd@burohappold.com>
Co-authored-by: Fraser Greenroyd <fraser.greenroyd@burohappold.com>
Co-authored-by: Fraser Greenroyd <fraser.greenroyd@burohappold.com>
Co-authored-by: Fraser Greenroyd <fraser.greenroyd@burohappold.com>
Co-authored-by: Fraser Greenroyd <fraser.greenroyd@burohappold.com>
Co-authored-by: Fraser Greenroyd <fraser.greenroyd@burohappold.com>
Copy link

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review looks good, happy to merge if @alexissantella is happy with the enum.

@FraserGreenroyd
Copy link

@BHoMBot check versioning
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 12, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning
  • check installer

There are 22 requests in the queue ahead of you.

@FraserGreenroyd
Copy link

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 12, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 6 requests in the queue ahead of you.

@travispotterBH
Copy link
Author

@BHoMBot copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 12, 2022

@travispotterBH sorry, I didn't understand.
Was that comment an instruction for me? If so, could you state again what check you would like me to do?
For a list of available instructions, please see this wiki page.

@travispotterBH
Copy link
Author

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 12, 2022

@travispotterBH to confirm, the following actions are now queued:

  • check copyright-compliance

Copy link

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reviewed following call with Alexis happy to merge.

@FraserGreenroyd
Copy link

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 12, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 96228c4 into main Sep 12, 2022
@FraserGreenroyd FraserGreenroyd deleted the BHoMAnalytics_Toolkit-#36-ImproveBHoMAnalyticsLogging branch September 12, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve BHoM Analytics Pop-UP Window
2 participants