-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve BHoM Analytics Pop Up Window #38
Improve BHoM Analytics Pop Up Window #38
Conversation
Previously, setting visibility of the forms only, caused issues with the input fields retaining their values. added a ResetForms() method which sets the input field values to "" or null.
Co-authored-by: Fraser Greenroyd <fraser.greenroyd@burohappold.com>
Co-authored-by: Fraser Greenroyd <fraser.greenroyd@burohappold.com>
Co-authored-by: Fraser Greenroyd <fraser.greenroyd@burohappold.com>
Co-authored-by: Fraser Greenroyd <fraser.greenroyd@burohappold.com>
Co-authored-by: Fraser Greenroyd <fraser.greenroyd@burohappold.com>
Co-authored-by: Fraser Greenroyd <fraser.greenroyd@burohappold.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review looks good, happy to merge if @alexissantella is happy with the enum.
@FraserGreenroyd to confirm, the following actions are now queued:
There are 22 requests in the queue ahead of you. |
@BHoMBot check required |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 6 requests in the queue ahead of you. |
@BHoMBot copyright-compliance |
@travispotterBH sorry, I didn't understand. |
@BHoMBot check copyright-compliance |
@travispotterBH to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code reviewed following call with Alexis happy to merge.
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
New PR for branch name compliance: #37
Issues addressed by this PR
Closes #36
Added Branding:
@FraserGreenroyd I need help knowing where the image should be placed, and referenced. Will need to ship with installer.
Image below:
Added custom UI for Revit:
Revit Self Assign Project Number, when Project Information is set:
Revit User Assign Project Number, when Project Information is not set:
Added custom UI for Grasshopper:
Changelog
Additional comments
@FraserGreenroyd @al-fisher requested modifications to the installer to update information about logging.