feat: update black_box() usage

See rust-lang/rust#133942, there's not much point in using `black_box()` on a unit type, especially since `map.insert()` has side-effects and will be executed.
BD103 · Dec 7, 2024 · 834f1c3 · 834f1c3
1 parent ab11ede
commit 834f1c3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/benches/benches/bevy_reflect/map.rs b/benches/benches/bevy_reflect/map.rs
@@ -265,7 +265,7 @@ fn dynamic_map_insert(criterion: &mut Criterion) {
                     |mut map| {
                         for i in 0..size as u64 {
                             let key = black_box(i);
-                            black_box(map.insert(key, i));
+                            map.insert(key, black_box(i));
                         }
                     },
                     BatchSize::SmallInput,

diff --git a/benches/benches/bevy_reflect/struct.rs b/benches/benches/bevy_reflect/struct.rs
@@ -313,7 +313,7 @@ fn dynamic_struct_insert(criterion: &mut Criterion) {
                 bencher.iter_batched(
                     || s.clone_dynamic(),
                     |mut s| {
-                        black_box(s.insert(black_box(&field), ()));
+                        s.insert(black_box(&field), ());
                     },
                     BatchSize::SmallInput,
                 );