Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : main_category_id가 처음 회원 가입시에는 undefined이기 때문에 optional로 변경 #388

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

hoooooony
Copy link
Contributor

  • Close #ISSUE_NUMBER

What is this PR? 🔍

  • 기능 :
  • issue : #

Changes 📝

main_category_id가 처음 회원 가입시에는 undefined이기 때문에 optional로 변경했는데 해당 값을 사용하는 곳에서 undefined된 값을 참조해서 에러가 발생하지 않는지 확인 부탁드립니다.

ScreenShot 📷

Test CheckList ✅

  • test 1
  • test 2
  • test 3

Precaution

✔️ Please check if the PR fulfills these requirements

  • It's submitted to the correct branch, not the develop branch unconditionally?
  • If on a hotfix branch, ensure it targets main?
  • There are no warning message when you run yarn lint

@hoooooony hoooooony requested a review from daepan January 16, 2025 15:17
@hoooooony hoooooony self-assigned this Jan 16, 2025
@github-actions github-actions bot requested a review from Yejin0070 January 16, 2025 15:18
Copy link
Contributor

@chaeseungyun chaeseungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다

@hoooooony hoooooony merged commit 90fe770 into develop Jan 17, 2025
1 check passed
@github-actions github-actions bot deleted the fix/signup-zod-error branch January 17, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants