Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: error code string으로 변경 #1370

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

BaeJinho4028
Copy link
Collaborator

🔥 연관 이슈

🚀 작업 내용

  1. 에러 코드 int -> String로 복구

@BaeJinho4028 BaeJinho4028 added the 버그 정상적으로 동작하지 않는 문제상황입니다. label Mar 14, 2025
@BaeJinho4028 BaeJinho4028 self-assigned this Mar 14, 2025
@BaeJinho4028 BaeJinho4028 changed the base branch from main to develop March 14, 2025 05:54
@BaeJinho4028 BaeJinho4028 requested a review from kih1015 March 14, 2025 05:55
Copy link
Contributor

@kih1015 kih1015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

핫핫픽스

Copy link
Collaborator

@Soundbar91 Soundbar91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 이거 의도된건 줄 알았는데 아니였군용

Copy link
Collaborator Author

@BaeJinho4028 BaeJinho4028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Soundbar91
레거시에서는 String이 메모리 잡아먹고, 빈값이라서 클라에서도 안쓰는 줄 알았는데 아니었군요.
클라이언트분들께 체킹 후 되돌리거나 적용하려 했는데, 충돌 잡다보니 놓친 것 같습니다.

Copy link

Unit Test Results

339 tests   338 ✔️  1m 45s ⏱️
  45 suites      1 💤
  45 files        0

Results for commit b92d863.

@BaeJinho4028 BaeJinho4028 merged commit c1ac556 into develop Mar 14, 2025
5 checks passed
@BaeJinho4028 BaeJinho4028 deleted the hotfix/1369-error-code-string branch March 14, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
버그 정상적으로 동작하지 않는 문제상황입니다.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

에러코드 int -> String
4 participants