Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[공통] useMediaQuery 추가 및 공통 페이지 모바일 뷰 추가 #169

Merged
merged 2 commits into from
May 16, 2024

Conversation

dooohun
Copy link
Contributor

@dooohun dooohun commented May 16, 2024

[Copy here issue number] request

  • 공통으로 사용하는 sidebar, topbar의 모바일 뷰 css 추가 (글씨 크기 및 버튼 크기, 사이드바 전체 크기를 알맞게 수정)
  • useMediaQuery 추가

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Did you merge recent main branch?

Screenshot

Topbar에서 가장 긴 타이틀을 예시로 가져왔습니다.
image
image

Precautions (main files for this PR ...)

  • emotion에서 사용하는 방식이 기존 scss와 달라 사용하는 방법 공유드립니다.
    useMediaQuery에 mobile을 통해 모바일 css를 따로 추가할 수 있습니다.
import { mobile } from 'util/hooks/useMediaQuery';

export const buttonContainer = css`
  display: flex;
  justify-content: flex-end;
  gap: 20px;

  ${mobile} {
    button {
      font-size: 12px;
      width: 65px;
      height: 35px;
      padding: 0;
    }
  }
`;
  • Close #ISSUE_NUMBER

@dooohun dooohun added the enhancement New feature or request label May 16, 2024
@dooohun dooohun self-assigned this May 16, 2024
Copy link
Contributor

@chaeseungyun chaeseungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿~

Copy link
Collaborator

@MinGu-Jeong MinGu-Jeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이제 모바일에서도 사용할 수 있겠네요 수고하셨습니다~

@dooohun dooohun merged commit 42f5127 into main May 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants