Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[동방 예약] 시간이 10분 밀리는 현상 해결 #162

Merged
merged 3 commits into from
Apr 8, 2024
Merged

[동방 예약] 시간이 10분 밀리는 현상 해결 #162

merged 3 commits into from
Apr 8, 2024

Conversation

dooohun
Copy link
Contributor

@dooohun dooohun commented Apr 7, 2024

[#159] request

  • 전체 코드에서 분의 범위를 설정하지 않아 생기는 에러로 파악
  • 기존 MINUTE_LIST를 수정함 ('10' -> '00-10')

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Did you merge recent main branch?

Screenshot

2024-04-07.8.48.19.mov
2024-04-07.8.48.43.mov

Precautions (main files for this PR ...)

@dooohun dooohun added the bug Something isn't working label Apr 7, 2024
@dooohun dooohun self-assigned this Apr 7, 2024
MinGu-Jeong
MinGu-Jeong approved these changes Apr 7, 2024
View reviewed changes
Copy link
Collaborator

@MinGu-Jeong MinGu-Jeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

로직 진짜 복잡하네요ㅋㅋㅋ
너무 수고많으셨습니다!!

chaeseungyun
chaeseungyun approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@chaeseungyun chaeseungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

복잡한 코드네용 고생하셨어요

src/page/Reservation/view/Week/index.tsx Show resolved Hide resolved
@dooohun dooohun merged commit eec27a5 into main Apr 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MinGu-Jeong MinGu-Jeong MinGu-Jeong approved these changes

@chaeseungyun chaeseungyun chaeseungyun approved these changes

@hanagertrudeKim hanagertrudeKim Awaiting requested review from hanagertrudeKim hanagertrudeKim is a code owner

@ChoiWonBeen ChoiWonBeen Awaiting requested review from ChoiWonBeen ChoiWonBeen is a code owner

Assignees

@dooohun dooohun

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[동방 예약] 주 에서 예약할 때 끝나는 시간이 동일하지 않음
3 participants
@dooohun @MinGu-Jeong @chaeseungyun