Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bitbucket fetcher test had unused code #71

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

wulmer
Copy link
Contributor

@wulmer wulmer commented Nov 20, 2024

Hi @einnhverr , one of the Bitbucket tests had some braces/indentation issue, please have a look at my fix.

@wulmer wulmer requested a review from einnhverr November 20, 2024 10:48
Copy link

Code Coverage Report

Project Statements Rate Branch Rate Indicator
packages/autopilot-utils 96.67% 90.23% 💚
dist/coverage/python 96.67% 90.23% 💚
apps/splunk-fetcher 92.51% 82.00% 💚
apps/sharepoint-fetcher 84.83% 76.62% 💚
apps/sharepoint-evaluator 94.09% 90.48% 💚
apps/sharepoint 83.98% 67.86% 💚
apps/security-scanner 0.00% 0.00% 💔
apps/pex-tool 93.07% 78.05% 💚
apps/pdf-signature-evaluator 67.48% 48.80% 💛
apps/papsr 98.25% 94.74% 💚
apps/filecheck 98.53% 96.30% 💚
apps/excel-tools 78.37% 62.89% 💛
apps/artifactory-fetcher 98.51% 92.86% 💚
Total 87.13% 75.70% 💚

Copy link
Contributor

@einnhverr einnhverr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I would recommend to also change to non-aliased API calls, e.g.toBeCalledWith() -> toHaveBeenCalledWith(). Since Vitest is tracking Jest APIs, and it appears there are plans to be removed in the future

@wulmer
Copy link
Contributor Author

wulmer commented Nov 20, 2024

LGTM. I would recommend to also change to non-aliased API calls, e.g.toBeCalledWith() -> toHaveBeenCalledWith(). Since Vitest is tracking Jest APIs, and it appears there are plans to be removed in the future

Thanks for the hint. I consider this out of scope for now, but sooner or later, someone has to deal with it.

@wulmer wulmer merged commit cc358b4 into main Nov 20, 2024
8 checks passed
@wulmer wulmer deleted the fix/incorrect-git-fetcher-test branch November 20, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants