Fix checkstyle breaks in EventGrid (#8639)

* Fix checkstyles. * Fix header. * Add suppressions and fix JLS order.
AzureSDKAutomation · Mar 4, 2020 · 2f5b92f · 2f5b92f
1 parent eeef082
commit 2f5b92f
Show file tree

Hide file tree

Showing 14 changed files with 157 additions and 192 deletions.
diff --git a/eng/code-quality-reports/src/main/resources/checkstyle/checkstyle-suppressions.xml b/eng/code-quality-reports/src/main/resources/checkstyle/checkstyle-suppressions.xml
@@ -36,6 +36,7 @@
   <suppress checks="Header" files=".*KeyVaultKeyResolverBCProviderTest.java"/>
   <suppress checks="Header" files=".*KeyVaultKeyResolverDefaultProviderTest.java"/>
   <suppress checks="Header" files="com.azure.core.http.netty.implementation.HttpProxyHandler"/>
+  <suppress checks="Header" files="eventgrid[/\\](models|implementation)[/\\].*\.java"/>
 
   <!-- Cryptography Client exception for service client instantiation as it provides client side crypto and is not entirely based on REST service -->
   <suppress checks="com.azure.tools.checkstyle.checks.ServiceClientCheck" files=".*CryptographyAsyncClient.java"/>
@@ -226,11 +227,11 @@
 
   <!-- Report AMQP retry attempts in static withRetry method. -->
   <suppress checks="com.azure.tools.checkstyle.checks.GoodLoggingCheck" files="com.azure.core.amqp.implementation.RetryUtil.java"/>
-  
+
   <!-- The Identity Azure Platform End to tend Test.-->
   <suppress checks="com.azure.tools.checkstyle.checks.GoodLoggingCheck" files="com.azure.endtoend.identity.IdentityTest.java"/>
     <suppress checks="com.azure.tools.checkstyle.checks.GoodLoggingCheck" files="com.azure.endtoend.identity.WebJobsIdentityTest.java"/>
-  
+
   <!-- Use the logger in a Utility static method. -->
   <suppress checks="com.azure.tools.checkstyle.checks.GoodLoggingCheck" files="com.azure.ai.textanalytics.Transforms.java" />
 

diff --git a/...rosoft-azure-eventgrid/src/main/java/com/microsoft/azure/eventgrid/DomainCredentials.java b/...rosoft-azure-eventgrid/src/main/java/com/microsoft/azure/eventgrid/DomainCredentials.java
@@ -1,9 +1,5 @@
-/**
- * Copyright (c) Microsoft Corporation. All rights reserved.
- * Licensed under the MIT License. See License.txt in the project root for
- * license information.
- */
-
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
 package com.microsoft.azure.eventgrid;
 
 import com.microsoft.rest.credentials.ServiceClientCredentials;

diff --git a/...icrosoft-azure-eventgrid/src/main/java/com/microsoft/azure/eventgrid/EventGridClient.java b/...icrosoft-azure-eventgrid/src/main/java/com/microsoft/azure/eventgrid/EventGridClient.java
@@ -1,11 +1,5 @@
-/**
- * Copyright (c) Microsoft Corporation. All rights reserved.
- * Licensed under the MIT License. See License.txt in the project root for
- * license information.
- *
- * Code generated by Microsoft (R) AutoRest Code Generator.
- */
-
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
 package com.microsoft.azure.eventgrid;
 
 import com.microsoft.azure.AzureClient;
@@ -15,10 +9,10 @@
 import com.microsoft.rest.ServiceCallback;
 import com.microsoft.rest.ServiceFuture;
 import com.microsoft.rest.ServiceResponse;
-import java.io.IOException;
-import java.util.List;
 import rx.Observable;
 
+import java.util.List;
+
 /**
  * The interface for EventGridClient class.
  */
@@ -115,7 +109,7 @@ public interface EventGridClient {
      * @throws IllegalArgumentException thrown if parameters fail the validation
      * @return the {@link ServiceFuture} object
      */
-    ServiceFuture<Void> publishEventsAsync(String topicHostname, List<EventGridEvent> events, final ServiceCallback<Void> serviceCallback);
+    ServiceFuture<Void> publishEventsAsync(String topicHostname, List<EventGridEvent> events, ServiceCallback<Void> serviceCallback);
 
     /**
      * Publishes a batch of events to an Azure Event Grid topic.

diff --git a/...crosoft-azure-eventgrid/src/main/java/com/microsoft/azure/eventgrid/TopicCredentials.java b/...crosoft-azure-eventgrid/src/main/java/com/microsoft/azure/eventgrid/TopicCredentials.java
@@ -1,9 +1,5 @@
-/**
- * Copyright (c) Microsoft Corporation. All rights reserved.
- * Licensed under the MIT License. See License.txt in the project root for
- * license information.
- */
-
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
 package com.microsoft.azure.eventgrid;
 
 import com.microsoft.rest.credentials.ServiceClientCredentials;

diff --git a/...ntgrid/src/main/java/com/microsoft/azure/eventgrid/customization/EventGridSubscriber.java b/...ntgrid/src/main/java/com/microsoft/azure/eventgrid/customization/EventGridSubscriber.java
@@ -1,8 +1,5 @@
-/**
- * Copyright (c) Microsoft Corporation. All rights reserved.
- * Licensed under the MIT License. See License.txt in the project root for
- * license information.
- */
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
 package com.microsoft.azure.eventgrid.customization;
 
 import com.fasterxml.jackson.databind.ObjectMapper;

diff --git a/...id/src/main/java/com/microsoft/azure/eventgrid/customization/SystemEventTypeMappings.java b/...id/src/main/java/com/microsoft/azure/eventgrid/customization/SystemEventTypeMappings.java
@@ -1,8 +1,5 @@
-/**
- * Copyright (c) Microsoft Corporation. All rights reserved.
- * Licensed under the MIT License. See License.txt in the project root for
- * license information.
- */
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
 package com.microsoft.azure.eventgrid.customization;
 
 import com.microsoft.azure.eventgrid.models.AppConfigurationKeyValueDeletedEventData;