Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
This PR refactors portions of the "connectedk8s proxy" command into a helper package to simplify the codebase and improve maintainability for future contributions.
It also removes the ADAL token implementation for Arc proxy authentication. This feature is deprecated, as the extension’s minimum required Azure CLI version is 2.64.0, and the transition to MSAL in the CLI was completed in version 2.30.0.
Lastly, this PR fixes a bug where Access Tokens (AT) passed to the proxy were not refreshed before expiry. Previously, tokens were refreshed alongside the Hybrid Connection (HC), which has a 3-hour expiry, while tokens expire after 1 hour. This change ensures that both are refreshed as needed.
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.