Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AT refresh for Proxy #27

Merged
merged 5 commits into from
Dec 5, 2024
Merged

Conversation

JorgeDaboub
Copy link
Collaborator

@JorgeDaboub JorgeDaboub commented Dec 4, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

This PR refactors portions of the "connectedk8s proxy" command into a helper package to simplify the codebase and improve maintainability for future contributions.

It also removes the ADAL token implementation for Arc proxy authentication. This feature is deprecated, as the extension’s minimum required Azure CLI version is 2.64.0, and the transition to MSAL in the CLI was completed in version 2.30.0.

Lastly, this PR fixes a bug where Access Tokens (AT) passed to the proxy were not refreshed before expiry. Previously, tokens were refreshed alongside the Hybrid Connection (HC), which has a 3-hour expiry, while tokens expire after 1 hour. This change ensures that both are refreshed as needed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@JorgeDaboub JorgeDaboub changed the title Add AT refresh on MSAL For Proxy Add AT refresh for Proxy Dec 4, 2024
@JorgeDaboub JorgeDaboub merged commit c9058ca into main Dec 5, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants