Tidying #25
Merged
Tidying #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makes the type annotations true again
bavneetsingh16
approved these changes
Nov 22, 2024
bavneetsingh16
pushed a commit
that referenced
this pull request
Feb 14, 2025
* ruff fix * remove duplicate code block * cleaner fix for no existing kubeconfig makes the type annotations true again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bavneetsingh16 I saw the 1.10.4 release and saw that this was mostly my bug, sorry about that. Here's a slight variation on your fix that makes the type annotations true again and restores pipeline happiness.
I assume that the failing ruff and mypy pipelines currently don't block merges of pull requests? I'd strongly suggest changing that. Obvs we have just demonstrated that it is still possible to go wrong anyway, but I am quite sure that in the long run this would catch more bugs than it allows.