Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for agent state before updating helm charts #18

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

dimbleby
Copy link
Collaborator

@dimbleby dimbleby commented Nov 8, 2024

As discussed, a sort-of fix for https://msazure.visualstudio.com/AzureArcPlatform/_workitems/edit/29816874

Not sure about some of the choices here, please consider

  • is it right to save throwing the exception to the end, or should we give up before updating the helm chart?
  • should we re-check the agent state after helm chart update anyway?
  • should we do the same re-ordering in connect as well as update?

And if we like this then we should expect to want to make the same change to the powershell CLI

@dimbleby dimbleby force-pushed the davidhotham/await-agent-state-earlier branch 2 times, most recently from 374921a to dc533fd Compare November 8, 2024 17:41
@dimbleby dimbleby force-pushed the davidhotham/await-agent-state-earlier branch from dc533fd to 7ea01d5 Compare November 8, 2024 17:43
@bavneetsingh16 bavneetsingh16 merged commit 867dacd into main Nov 11, 2024
5 of 7 checks passed
@bavneetsingh16 bavneetsingh16 deleted the davidhotham/await-agent-state-earlier branch November 11, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants