Onboard Id Web to Threading Analyzers #3041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmprieur
reviewed
Sep 27, 2024
There was a problem hiding this comment.
LGTM at first review, @westin-m
Make sure you run end to end tests with credentials.
There was a race condition at some point, which is why the credential loaders used GetAwaiter.GetAsync().
I'm surprised there is no change in the public API?
src/Microsoft.Identity.Web.Certificate/DefaultCertificateLoader.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Identity.Web/AzureADB2COpenIDConnectEventHandlers.cs
Outdated
Show resolved
Hide resolved
msbw2
reviewed
Sep 27, 2024
src/Microsoft.Identity.Web.OWIN/OpenIdConnectCachingSecurityTokenProvider.cs
Outdated
Show resolved
Hide resolved
kllysng
reviewed
Sep 27, 2024
src/Microsoft.Identity.Web/AzureADB2COpenIDConnectEventHandlers.cs
Outdated
Show resolved
Hide resolved
kllysng
reviewed
Sep 27, 2024
src/Microsoft.Identity.Web/AzureADB2COpenIDConnectEventHandlers.cs
Outdated
Show resolved
Hide resolved
jennyf19
requested changes
Sep 29, 2024
I've added this to the description |
pmaytak
reviewed
Sep 30, 2024
pmaytak
reviewed
Oct 1, 2024
pmaytak
requested changes
Oct 1, 2024
src/Microsoft.Identity.Web.OWIN/OpenIdConnectCachingSecurityTokenProvider.cs
Outdated
Show resolved
Hide resolved
pmaytak
approved these changes
Oct 9, 2024
JoshLozensky
reviewed
Oct 9, 2024
tests/Microsoft.Identity.Web.Test.Integration/AcquireTokenForAppIntegrationTests.cs
Outdated
Show resolved
Hide resolved
JoshLozensky
requested changes
Oct 9, 2024
There was a problem hiding this comment.
ConfigureAwait(false) is not compatible with XUnit this is what had been causing our flaky tests previously
remove configureawait from theory test
JoshLozensky
approved these changes
Oct 10, 2024
jmprieur
reviewed
Oct 10, 2024
src/Microsoft.Identity.Web.DownstreamApi/PublicAPI/net462/InternalAPI.Unshipped.txt
Show resolved
Hide resolved
src/Microsoft.Identity.Web.TokenAcquisition/PublicAPI/net462/InternalAPI.Unshipped.txt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following E2E scenarios were tested using the corresponding devapps:
Web app calls web api call graph
B2C web app calls web api
Owin
Blazer server calls web api
Blazer server B2C calls api
Ciam web app calls api
Web app calls graph
Deamon console calling downstream api, graph
All are working as expected.