Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AzureRegion while calculating key #3002

Merged
merged 5 commits into from
Sep 9, 2024
Merged

Conversation

SaurabhMSFT
Copy link
Contributor

@SaurabhMSFT SaurabhMSFT commented Sep 2, 2024

Use AzureRegion while calculating key

Description

AzureRegion was used while calculating key in DefaultTokenAcquirerFactoryImplementation but not in TokenAcquisition.cs file. Now the GetKey method in TokenAcquisition calls the method with same name in DefaultTokenAcquirerFactoryImplementation . This will ensure that both methods rely on the same set of attributes while creating key.

Fixes #{3001194} (https://identitydivision.visualstudio.com/Engineering/_workitems/edit/3001194)

@SaurabhMSFT SaurabhMSFT requested a review from a team as a code owner September 2, 2024 11:36
@bgavrilMS
Copy link
Member

We should have a bug for this @SaurabhMSFT .

LGTM

@bgavrilMS
Copy link
Member

Use AzureRegion while calculating key

Description

AzureRegion was used while calculating key in DefaultTokenAcquirerFactoryImplementation but not in TokenAcquisition.cs file. Now the GetKey method in TokenAcquisition calls the method with same name in DefaultTokenAcquirerFactoryImplementation . This will ensure that both methods rely on the same set of attributes while creating key.

Fixes #{3001194} (https://identitydivision.visualstudio.com/Engineering/_workitems/edit/3001194)

I'd be surprised if this is sufficient to fix the bug you referenced, but no objection to trying it out.

@SaurabhMSFT
Copy link
Contributor Author

Use AzureRegion while calculating key

Description

AzureRegion was used while calculating key in DefaultTokenAcquirerFactoryImplementation but not in TokenAcquisition.cs file. Now the GetKey method in TokenAcquisition calls the method with same name in DefaultTokenAcquirerFactoryImplementation . This will ensure that both methods rely on the same set of attributes while creating key.
Fixes #{3001194} (https://identitydivision.visualstudio.com/Engineering/_workitems/edit/3001194)

I'd be surprised if this is sufficient to fix the bug you referenced, but no objection to trying it out.

This bug required two fixes. One in this branch and the second in https://identitydivision.visualstudio.com/DevEx/_git/MISE/pullrequest/14342

@SaurabhMSFT SaurabhMSFT merged commit 887df01 into master Sep 9, 2024
5 checks passed
@SaurabhMSFT SaurabhMSFT deleted the saugautam/tokenkey branch September 9, 2024 09:00
@jennyf19 jennyf19 added this to the 3.2.0 milestone Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants