-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use AzureRegion while calculating key #3002
Conversation
We should have a bug for this @SaurabhMSFT . LGTM |
src/Microsoft.Identity.Web.TokenAcquisition/TokenAcquisition.cs
Outdated
Show resolved
Hide resolved
I'd be surprised if this is sufficient to fix the bug you referenced, but no objection to trying it out. |
This bug required two fixes. One in this branch and the second in https://identitydivision.visualstudio.com/DevEx/_git/MISE/pullrequest/14342 |
Use AzureRegion while calculating key
Description
AzureRegion was used while calculating key in DefaultTokenAcquirerFactoryImplementation but not in TokenAcquisition.cs file. Now the GetKey method in TokenAcquisition calls the method with same name in DefaultTokenAcquirerFactoryImplementation . This will ensure that both methods rely on the same set of attributes while creating key.
Fixes #{3001194} (https://identitydivision.visualstudio.com/Engineering/_workitems/edit/3001194)