Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump com.nimbusds.oauth2-oidc-sdk from 11.9.1 to 11.18 #859

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

crimsonvspurple
Copy link
Contributor

Vulnerabilities from dependencies:
CVE-2024-34447
CVE-2024-30172
CVE-2024-30171
CVE-2024-29857

@crimsonvspurple crimsonvspurple requested a review from a team as a code owner August 29, 2024 08:19
@bgavrilMS
Copy link
Member

@Avery-Dunn - why do we need this dependency? Is it to create the client assertion from a certificate for confidential client flows? Maybe in the long run it's better to just have MSAL do that from scratch? It's just a json string + signature.

@crimsonvspurple
Copy link
Contributor Author

Fully agree with you, remove if possible.

I could not find any PR for this. Shouldn't dependabot open PR for these automatically?

@bgavrilMS
Copy link
Member

Fully agree with you, remove if possible.

I could not find any PR for this. Shouldn't dependabot open PR for these automatically?

Yes, I am not sure why Dependabot didn't alert us. The security tab doesn't show these.

@Avery-Dunn
Copy link
Collaborator

Avery-Dunn commented Aug 29, 2024

@bgavrilMS : We use it several places for standard OIDC stuff about tokens, credentials, authorization grants, etc. We could probably remove it, but it would be quite a few code changes. Seems like we have to update this dependency at least once a year, so maybe removing it is worth the effort.

As for why dependabot didn't create a PR for us: the vulnerability is in an optional dependency of oauth2-oidc-sdk, and my best guess is that we don't use the part of oauth2-oidc-sdk that's vulnerable:

Regardless, thanks for letting us know @crimsonvspurple !

@Avery-Dunn Avery-Dunn merged commit 6f431a3 into AzureAD:dev Aug 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants